linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org,
	syzbot <syzbot+6f39a9deb697359fe520@syzkaller.appspotmail.com>,
	syzkaller-bugs@googlegroups.com
Subject: Re: BUG: MAX_STACK_TRACE_ENTRIES too low! (2)
Date: Fri, 12 Jul 2019 10:55:36 +0200	[thread overview]
Message-ID: <20190712085536.GP3402@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <e10e95c7-b832-5560-e3ca-3ce584bc0ca3@acm.org>

On Thu, Jul 11, 2019 at 11:53:12AM -0700, Bart Van Assche wrote:
> On 7/10/19 3:09 PM, Peter Zijlstra wrote:
> > One thing I mentioned when Thomas did the unwinder API changes was
> > trying to move lockdep over to something like stackdepot.
> > 
> > We can't directly use stackdepot as is, because it uses locks and memory
> > allocation, but we could maybe add a lower level API to it and use that
> > under the graph_lock() on static storage or something.
> > 
> > Otherwise we'll have to (re)implement something like it.
> > 
> > I've not looked at it in detail.
> 
> Hi Peter,
> 
> Is something like the untested patch below perhaps what you had in mind?

Most excellent, yes! Now I suppose the $64000 question is if it actually
reduces the amount of storage we use for stack traces..

Seems to boot just fine.. :-)

  reply	other threads:[~2019-07-12  8:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29 10:42 BUG: MAX_STACK_TRACE_ENTRIES too low! (2) syzbot
2019-03-30 11:10 ` syzbot
2019-03-30 21:58 ` syzbot
2019-03-31  2:17   ` Bart Van Assche
2019-07-10  5:30     ` Eric Biggers
2019-07-10 14:19       ` Bart Van Assche
2019-07-10 17:00         ` Eric Biggers
2019-07-10 17:21           ` Eric Biggers
2019-07-10 17:46             ` Bart Van Assche
2019-07-10 18:02               ` Eric Biggers
2019-07-10 18:36                 ` Bart Van Assche
2019-07-10 18:44                   ` Eric Dumazet
2019-07-10 19:09                     ` Bart Van Assche
2019-07-10 20:47                       ` Eric Dumazet
2019-07-10 21:23                         ` Bart Van Assche
2019-07-10 22:09                           ` Peter Zijlstra
2019-07-11 18:53                             ` Bart Van Assche
2019-07-12  8:55                               ` Peter Zijlstra [this message]
2019-07-12 23:03                                 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190712085536.GP3402@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bvanassche@acm.org \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=syzbot+6f39a9deb697359fe520@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).