From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C3BC742BA for ; Fri, 12 Jul 2019 12:40:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FC1D21019 for ; Fri, 12 Jul 2019 12:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562935252; bh=GGVAeyUW5TCw69UXQh9EgpgOs9SzBn7k9zjPgxJ/r1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xmkac7EFE/2eL7yzMdmdn2v/ZgPGbQYSc4n3gmsVcey5mgBWL9q+jv7V0OWqTaInO a4BSCLm3WG7JJxUq1OH2HTVFlzF/PWQgimxEqWLSK8QrEJKX5jJN7poonHjXyaNkTb 4q2UV7bENvJG10PbbwfyA32R8RDVvBUUuPmd2xXc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728144AbfGLMYp (ORCPT ); Fri, 12 Jul 2019 08:24:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:33448 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728160AbfGLMYi (ORCPT ); Fri, 12 Jul 2019 08:24:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA46B2084B; Fri, 12 Jul 2019 12:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562934277; bh=GGVAeyUW5TCw69UXQh9EgpgOs9SzBn7k9zjPgxJ/r1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xXDgXZZcRBrxg3n9FJLpeBBEKXT+P8FA/qrQ8WNpsOQzVjzj5YKRjrofk2YoSmY4d zABLBNRPE/77h+RMnhQawPvn/b1TN7zizP9JA2YgCv1gIQm4cXCJRfrd2fJ36iSL1P i54ycK8/R28frUbZ5p0bJstfBzOqrt9hVDFDIaBM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Dan Carpenter , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 50/91] net: lio_core: fix potential sign-extension overflow on large shift Date: Fri, 12 Jul 2019 14:18:53 +0200 Message-Id: <20190712121624.331932688@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190712121621.422224300@linuxfoundation.org> References: <20190712121621.422224300@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 9476274093a0e79b905f4cd6cf6d149f65e02c17 ] Left shifting the signed int value 1 by 31 bits has undefined behaviour and the shift amount oq_no can be as much as 63. Fix this by using BIT_ULL(oq_no) instead. Addresses-Coverity: ("Bad shift operation") Fixes: f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters") Signed-off-by: Colin Ian King Reviewed-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index 8093c5eafea2..781814835a4f 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c @@ -985,7 +985,7 @@ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct) if (droq->ops.poll_mode) { droq->ops.napi_fn(droq); - oct_priv->napi_mask |= (1 << oq_no); + oct_priv->napi_mask |= BIT_ULL(oq_no); } else { tasklet_schedule(&oct_priv->droq_tasklet); } -- 2.20.1