From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Igor Opaniuk <igor.opaniuk@toradex.com>,
Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: [PATCH v3 3/6] ASoC: sgtl5000: Fix of unmute outputs on probe
Date: Fri, 12 Jul 2019 14:56:03 +0000 [thread overview]
Message-ID: <20190712145550.27500-4-oleksandr.suvorov@toradex.com> (raw)
In-Reply-To: <20190712145550.27500-1-oleksandr.suvorov@toradex.com>
To enable "zero cross detect" for ADC/HP, change
HP_ZCD_EN/ADC_ZCD_EN bits only instead of writing the whole
CHIP_ANA_CTRL register.
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Igor Opaniuk <igor.opaniuk@toradex.com>
---
Changes in v3: None
Changes in v2:
- Fix patch formatting
sound/soc/codecs/sgtl5000.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index bb58c997c6914..e813a37910af4 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -1289,6 +1289,7 @@ static int sgtl5000_probe(struct snd_soc_component *component)
int ret;
u16 reg;
struct sgtl5000_priv *sgtl5000 = snd_soc_component_get_drvdata(component);
+ unsigned int zcd_mask = SGTL5000_HP_ZCD_EN | SGTL5000_ADC_ZCD_EN;
/* power up sgtl5000 */
ret = sgtl5000_set_power_regs(component);
@@ -1316,9 +1317,8 @@ static int sgtl5000_probe(struct snd_soc_component *component)
0x1f);
snd_soc_component_write(component, SGTL5000_CHIP_PAD_STRENGTH, reg);
- snd_soc_component_write(component, SGTL5000_CHIP_ANA_CTRL,
- SGTL5000_HP_ZCD_EN |
- SGTL5000_ADC_ZCD_EN);
+ snd_soc_component_update_bits(component, SGTL5000_CHIP_ANA_CTRL,
+ zcd_mask, zcd_mask);
snd_soc_component_update_bits(component, SGTL5000_CHIP_MIC_CTRL,
SGTL5000_BIAS_R_MASK,
--
2.20.1
next prev parent reply other threads:[~2019-07-12 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 14:55 [PATCH v3 0/6] VAG power control improvement for sgtl5000 codec Oleksandr Suvorov
2019-07-12 14:56 ` [PATCH v3 1/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control Oleksandr Suvorov
2019-07-12 14:56 ` [PATCH v3 2/6] ASoC: sgtl5000: add ADC mute control Oleksandr Suvorov
2019-07-12 14:56 ` Oleksandr Suvorov [this message]
2019-07-12 14:56 ` [PATCH v3 4/6] ASoC: sgtl5000: Fix charge pump source assignment Oleksandr Suvorov
2019-07-12 14:56 ` [PATCH v3 5/6] ASoC: Define a set of DAPM pre/post-up events Oleksandr Suvorov
2019-07-12 14:56 ` [PATCH v3 6/6] ASoC: sgtl5000: Improve VAG power and mute control Oleksandr Suvorov
2019-07-14 17:17 ` Cezary Rojewski
2019-07-17 14:24 ` Oleksandr Suvorov
2019-07-15 19:06 ` [PATCH v3 0/6] VAG power control improvement for sgtl5000 codec Fabio Estevam
2019-07-17 16:34 ` Oleksandr Suvorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712145550.27500-4-oleksandr.suvorov@toradex.com \
--to=oleksandr.suvorov@toradex.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=igor.opaniuk@toradex.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).