From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition
Date: Sat, 13 Jul 2019 12:21:06 +0900 [thread overview]
Message-ID: <20190713032106.8509-1-yamada.masahiro@socionext.com> (raw)
The KBUILD_ARFLAGS addition in arch/powerpc/Makefile has never worked
in a useful way because it is always overridden by the following code
in the top Makefile:
# use the deterministic mode of AR if available
KBUILD_ARFLAGS := $(call ar-option,D)
The code in the top Makefile was added in 2011, by commit 40df759e2b9e
("kbuild: Fix build with binutils <= 2.19").
The KBUILD_ARFLAGS addition for ppc has always been dead code from the
beginning.
Nobody has reported a problem since 43c9127d94d6 ("powerpc: Add option
to use thin archives"), so this code was unneeded.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/powerpc/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index c345b79414a9..46ed198a3aa3 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -112,7 +112,6 @@ ifeq ($(HAS_BIARCH),y)
KBUILD_CFLAGS += -m$(BITS)
KBUILD_AFLAGS += -m$(BITS) -Wl,-a$(BITS)
KBUILD_LDFLAGS += -m elf$(BITS)$(LDEMULATION)
-KBUILD_ARFLAGS += --target=elf$(BITS)-$(GNUTARGET)
endif
cflags-$(CONFIG_STACKPROTECTOR) += -mstack-protector-guard=tls
--
2.17.1
next reply other threads:[~2019-07-13 3:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 3:21 Masahiro Yamada [this message]
2019-07-13 12:47 ` [PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition Segher Boessenkool
2019-07-13 13:16 ` Segher Boessenkool
2019-07-13 22:45 ` Masahiro Yamada
2019-07-13 23:54 ` Segher Boessenkool
2019-07-15 7:05 ` Michael Ellerman
2019-07-15 7:29 ` Segher Boessenkool
2019-07-15 12:03 ` Masahiro Yamada
2019-07-15 18:16 ` Segher Boessenkool
2019-07-16 7:14 ` Masahiro Yamada
2019-07-16 12:15 ` Michael Ellerman
2019-07-17 14:38 ` Segher Boessenkool
2019-07-17 15:19 ` Masahiro Yamada
2019-07-17 16:46 ` Segher Boessenkool
2019-07-18 2:19 ` Masahiro Yamada
2019-07-18 20:46 ` Segher Boessenkool
2019-07-19 3:39 ` Michael Ellerman
2019-08-19 4:25 ` Masahiro Yamada
2019-08-28 4:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190713032106.8509-1-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).