From: David Miller <davem@davemloft.net>
To: efremov@linux.com
Cc: csully@google.com, sagis@google.com, jonolson@google.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gve: Remove the exporting of gve_probe
Date: Sun, 14 Jul 2019 12:13:12 -0700 (PDT) [thread overview]
Message-ID: <20190714.121312.1192239158322085095.davem@davemloft.net> (raw)
In-Reply-To: <20190714120225.15279-1-efremov@linux.com>
From: Denis Efremov <efremov@linux.com>
Date: Sun, 14 Jul 2019 15:02:25 +0300
> The function gve_probe is declared static and marked EXPORT_SYMBOL, which
> is at best an odd combination. Because the function is not used outside of
> the drivers/net/ethernet/google/gve/gve_main.c file it is defined in, this
> commit removes the EXPORT_SYMBOL() marking.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
Applied, thanks.
prev parent reply other threads:[~2019-07-14 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 12:02 [PATCH] gve: Remove the exporting of gve_probe Denis Efremov
2019-07-14 19:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714.121312.1192239158322085095.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=csully@google.com \
--cc=efremov@linux.com \
--cc=jonolson@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sagis@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).