From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5D88C76191 for ; Mon, 15 Jul 2019 14:07:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7ADE120868 for ; Mon, 15 Jul 2019 14:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563199675; bh=OYEwGVmIPNLLr8M63NDjwv0pbARc87LufXdORz3byx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BBwOEWtyjBI/eVW3PJWe/kn/ZFH48NvoB+aN7U8K6CheP6EpPHZS3ng6Ms/y4gKJT 4nstHfH0qRR2KTFxBiBxdUfYckIYjcwj/846BSDmCS3bLj2Cy51mGrPxc81w1Az2qe RVtdpY3O27dhA6IbX2pNxswuE9oZc6fXONFqAiFc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388417AbfGOOHy (ORCPT ); Mon, 15 Jul 2019 10:07:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:56872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388409AbfGOOHu (ORCPT ); Mon, 15 Jul 2019 10:07:50 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1A942081C; Mon, 15 Jul 2019 14:07:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563199670; bh=OYEwGVmIPNLLr8M63NDjwv0pbARc87LufXdORz3byx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sI8b6/goaoucA/9dg6FbigtrLBOqMDO3D3XHyzbARuUu/1QeHs6GUYhR83jdjKPpl WusfKl2Yqk6vbhkFAscHzlFrQ9DXzqlkMRVZkBXgkVYYGkx6qfQftY/eODrmaiJr0S KDFPUU1k0k8XPitxbuxZqnCZmn31m/nHyvFff12M= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Julian Wiedmann , Heiko Carstens , Sasha Levin , linux-s390@vger.kernel.org Subject: [PATCH AUTOSEL 5.1 067/219] s390/qdio: handle PENDING state for QEBSM devices Date: Mon, 15 Jul 2019 10:01:08 -0400 Message-Id: <20190715140341.6443-67-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715140341.6443-1-sashal@kernel.org> References: <20190715140341.6443-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julian Wiedmann [ Upstream commit 04310324c6f482921c071444833e70fe861b73d9 ] When a CQ-enabled device uses QEBSM for SBAL state inspection, get_buf_states() can return the PENDING state for an Output Queue. get_outbound_buffer_frontier() isn't prepared for this, and any PENDING buffer will permanently stall all further completion processing on this Queue. This isn't a concern for non-QEBSM devices, as get_buf_states() for such devices will manually turn PENDING buffers into EMPTY ones. Fixes: 104ea556ee7f ("qdio: support asynchronous delivery of storage blocks") Signed-off-by: Julian Wiedmann Signed-off-by: Heiko Carstens Signed-off-by: Sasha Levin --- drivers/s390/cio/qdio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/s390/cio/qdio_main.c b/drivers/s390/cio/qdio_main.c index 9537e656e927..06b94b2ee199 100644 --- a/drivers/s390/cio/qdio_main.c +++ b/drivers/s390/cio/qdio_main.c @@ -738,6 +738,7 @@ static int get_outbound_buffer_frontier(struct qdio_q *q) switch (state) { case SLSB_P_OUTPUT_EMPTY: + case SLSB_P_OUTPUT_PENDING: /* the adapter got it */ DBF_DEV_EVENT(DBF_INFO, q->irq_ptr, "out empty:%1d %02x", q->nr, count); -- 2.20.1