From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 03/13] ARM: tegra: Propagate error from tegra_idle_lp2_last()
Date: Mon, 15 Jul 2019 20:26:19 +0300 [thread overview]
Message-ID: <20190715172629.4437-4-digetx@gmail.com> (raw)
In-Reply-To: <20190715172629.4437-1-digetx@gmail.com>
The cpu_suspend() may fail, it's never good to lose information about
failure because it may become very useful for the caller. The new CPUIDLE
driver will handle all of possible error cases, including the case of
tegra_idle_lp2_last() failure.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
arch/arm/mach-tegra/pm.c | 8 ++++++--
arch/arm/mach-tegra/pm.h | 2 +-
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c
index 2f6fb54be9f8..f9c9bce9e15d 100644
--- a/arch/arm/mach-tegra/pm.c
+++ b/arch/arm/mach-tegra/pm.c
@@ -189,14 +189,16 @@ static void tegra_pm_set(enum tegra_suspend_mode mode)
tegra_pmc_enter_suspend_mode(mode);
}
-void tegra_idle_lp2_last(void)
+int tegra_idle_lp2_last(void)
{
+ int err;
+
tegra_pm_set(TEGRA_SUSPEND_LP2);
cpu_cluster_pm_enter();
suspend_cpu_complex();
- cpu_suspend(PHYS_OFFSET - PAGE_OFFSET, &tegra_sleep_cpu);
+ err = cpu_suspend(PHYS_OFFSET - PAGE_OFFSET, &tegra_sleep_cpu);
/*
* Resume L2 cache if it wasn't re-enabled early during resume,
@@ -208,6 +210,8 @@ void tegra_idle_lp2_last(void)
restore_cpu_complex();
cpu_cluster_pm_exit();
+
+ return err;
}
enum tegra_suspend_mode tegra_pm_validate_suspend_mode(
diff --git a/arch/arm/mach-tegra/pm.h b/arch/arm/mach-tegra/pm.h
index 3f3164ad04b7..ae68fc7db576 100644
--- a/arch/arm/mach-tegra/pm.h
+++ b/arch/arm/mach-tegra/pm.h
@@ -25,7 +25,7 @@ void tegra30_sleep_core_init(void);
void tegra_clear_cpu_in_lp2(void);
void tegra_set_cpu_in_lp2(void);
-void tegra_idle_lp2_last(void);
+int tegra_idle_lp2_last(void);
extern void (*tegra_tear_down_cpu)(void);
#ifdef CONFIG_PM_SLEEP
--
2.22.0
next prev parent reply other threads:[~2019-07-15 17:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 17:26 [PATCH v3 00/13] Consolidate and improve NVIDIA Tegra CPUIDLE driver(s) Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 01/13] ARM: tegra: Remove cpuidle drivers to replace them with a new driver Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 02/13] ARM: tegra: Change tegra_set_cpu_in_lp2() type to void Dmitry Osipenko
2019-07-15 17:26 ` Dmitry Osipenko [this message]
2019-07-15 17:26 ` [PATCH v3 04/13] ARM: tegra: Compile sleep-tegra20/30.S unconditionally Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 05/13] ARM: tegra: Expose PM functions required for new cpuidle driver Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 06/13] ARM: tegra: Rename some of the newly exposed PM functions Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 07/13] ARM: tegra: Add tegra_pm_park_secondary_cpu() Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 08/13] clk: tegra: Add missing stubs for the case of !CONFIG_PM_SLEEP Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 09/13] cpuidle: Introduce unified driver for NVIDIA Tegra SoCs Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 10/13] cpuidle: tegra: Support CPU cluster power-down state on Tegra30 Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 11/13] ARM: tegra: Create simple platform device for cpuidle driver Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 12/13] ARM: multi_v7_defconfig: Enable Tegra " Dmitry Osipenko
2019-07-15 17:26 ` [PATCH v3 13/13] ARM: tegra: Enable Tegra cpuidle driver in tegra_defconfig Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715172629.4437-4-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).