From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Laura Garcia <nevola@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Netfilter Development Mailing list
<netfilter-devel@vger.kernel.org>
Subject: Re: linux-next: Tree for Jul 15 (HEADERS_TEST w/ netfilter tables offload)
Date: Mon, 15 Jul 2019 20:09:05 +0200 [thread overview]
Message-ID: <20190715180905.rytaht5kslpbatcy@salvia> (raw)
In-Reply-To: <CAK7LNAS0rX_SRXqb=N=Td-DFNWd=PytDFje12gYh2pYNRBVAJA@mail.gmail.com>
On Tue, Jul 16, 2019 at 02:56:09AM +0900, Masahiro Yamada wrote:
> On Tue, Jul 16, 2019 at 2:33 AM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> >
> > On Mon, Jul 15, 2019 at 07:28:04PM +0200, Laura Garcia wrote:
> > > CC'ing netfilter.
> > >
> > > On Mon, Jul 15, 2019 at 6:45 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> > > >
> > > > On 7/14/19 9:48 PM, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > >
> > > > > Please do not add v5.4 material to your linux-next included branches
> > > > > until after v5.3-rc1 has been released.
> > > > >
> > > > > Changes since 20190712:
> > > > >
> > > >
> > > > Hi,
> > > >
> > > > I am seeing these build errors from HEADERS_TEST (or KERNEL_HEADERS_TEST)
> > > > for include/net/netfilter/nf_tables_offload.h.s:
> > > >
> > > > CC include/net/netfilter/nf_tables_offload.h.s
> > [...]
> > > > Should this header file not be tested?
>
> This means you must endlessly exclude
> headers that include nf_tables.h
>
>
> > Yes, it should indeed be added.
>
> Adding 'header-test-' is the last resort.
OK, so policy now is that all internal headers should compile
standalone, right?
I can have a look and make it compile standalone.
next prev parent reply other threads:[~2019-07-15 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 4:48 linux-next: Tree for Jul 15 Stephen Rothwell
2019-07-15 16:43 ` linux-next: Tree for Jul 15 (HEADERS_TEST w/ netfilter tables offload) Randy Dunlap
2019-07-15 17:28 ` Laura Garcia
2019-07-15 17:33 ` Pablo Neira Ayuso
2019-07-15 17:56 ` Masahiro Yamada
2019-07-15 18:09 ` Pablo Neira Ayuso [this message]
2019-07-16 6:44 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715180905.rytaht5kslpbatcy@salvia \
--to=pablo@netfilter.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nevola@gmail.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).