From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71018C76188 for ; Tue, 16 Jul 2019 14:03:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5648B206C2 for ; Tue, 16 Jul 2019 14:03:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387825AbfGPOD0 (ORCPT ); Tue, 16 Jul 2019 10:03:26 -0400 Received: from foss.arm.com ([217.140.110.172]:35354 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728004AbfGPODZ (ORCPT ); Tue, 16 Jul 2019 10:03:25 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 709A5337; Tue, 16 Jul 2019 07:03:24 -0700 (PDT) Received: from e110439-lin (e110439-lin.cambridge.arm.com [10.1.194.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1312E3F59C; Tue, 16 Jul 2019 07:03:21 -0700 (PDT) Date: Tue, 16 Jul 2019 15:03:20 +0100 From: Patrick Bellasi To: Michal =?utf-8?Q?Koutn=C3=BD?= Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Vincent Guittot , Viresh Kumar , Paul Turner , Quentin Perret , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan , Alessio Balsini Subject: Re: [PATCH v11 0/5] Add utilization clamping support (CGroups API) Message-ID: <20190716140319.hdmgcuevnpwdqobl@e110439-lin> References: <20190708084357.12944-1-patrick.bellasi@arm.com> <20190715165116.GB21982@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190715165116.GB21982@blackbody.suse.cz> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-Jul 18:51, Michal Koutný wrote: > Hello Patrick. Hi Michal, > I took a look at your series and I've posted some notes to your patches. thanks for your review! > One applies more to the series overall -- I see there is enum uclamp_id > defined but at many places (local variables, function args) int or > unsigned int is used. Besides the inconsistency, I think it'd be nice to > use the enum at these places. Right, I think in some of the original versions I had few code paths where it was not possible to use enum values. That seems no more the case. Since this change is likely affecting also core bits already merged in 5.3, in v12 I'm going to add a bulk rename patch at the end of the series, so that we can keep a better tracking of this change. > (Also, I may suggest CCing ML cgroups@vger.kernel.org where more eyes > may be available to the cgroup part of your series.) Good point, I'll add that for the upcoming v12 posting. Cheers, Patrick -- #include Patrick Bellasi