From: Pavel Machek <pavel@ucw.cz>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, jacek.anaszewski@gmail.com,
dmurphy@ti.com, linux-leds@vger.kernel.org
Subject: Re: [PATCH 5/6] leds: apu: fix error on probing failure
Date: Tue, 16 Jul 2019 21:28:05 +0200 [thread overview]
Message-ID: <20190716192805.GE10400@amd> (raw)
In-Reply-To: <1563202653-20994-6-git-send-email-info@metux.net>
[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]
On Mon 2019-07-15 16:57:32, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <info@metux.net>
>
> The current error message on failed probing tends to be a bit
> misleading. Fix it to tell exactly that an APU v1 was not found.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> drivers/leds/leds-apu.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/leds/leds-apu.c b/drivers/leds/leds-apu.c
> index 451cb9f..892fea7 100644
> --- a/drivers/leds/leds-apu.c
> +++ b/drivers/leds/leds-apu.c
> @@ -170,13 +170,9 @@ static int __init apu_led_init(void)
> struct platform_device *pdev;
> int err;
>
> - if (!dmi_match(DMI_SYS_VENDOR, "PC Engines")) {
> - pr_err("No PC Engines board detected\n");
> - return -ENODEV;
> - }
> - if (!(dmi_match(DMI_PRODUCT_NAME, "APU"))) {
> - pr_err("Unknown PC Engines board: %s\n",
> - dmi_get_system_info(DMI_PRODUCT_NAME));
> + if (!(dmi_match(DMI_SYS_VENDOR, "PC Engines") &&
> + dmi_match(DMI_PRODUCT_NAME, "APU"))) {
> + pr_err("No PC Engines APUv1 board detected\n");
You may want to add here: "For APUv2,3 support, enable CONFIG_xxx".
If you have any APUv2 users (and you may), this si chance to get their
attention.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-07-16 19:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:57 leds: apu: drop obsolete support for apu>=2 Enrico Weigelt, metux IT consult
2019-07-15 14:57 ` [PATCH 1/6] leds: apu: drop superseeded apu2/3 led support Enrico Weigelt, metux IT consult
2019-07-16 19:30 ` Pavel Machek
2019-07-17 14:28 ` Enrico Weigelt, metux IT consult
2019-07-15 14:57 ` [PATCH 2/6] leds: apu: drop enum_apu_led_platform_types Enrico Weigelt, metux IT consult
2019-07-16 19:25 ` Pavel Machek
2019-07-15 14:57 ` [PATCH 3/6] leds: apu: drop iosize field from priv data Enrico Weigelt, metux IT consult
2019-07-16 19:25 ` Pavel Machek
2019-07-15 14:57 ` [PATCH 4/6] leds: apu: drop profile " Enrico Weigelt, metux IT consult
2019-07-16 19:26 ` Pavel Machek
2019-07-15 14:57 ` [PATCH 5/6] leds: apu: fix error on probing failure Enrico Weigelt, metux IT consult
2019-07-16 19:28 ` Pavel Machek [this message]
2019-07-17 14:29 ` Enrico Weigelt, metux IT consult
2019-07-17 16:37 ` Jacek Anaszewski
2019-07-22 11:57 ` [PATCH v2] leds: apu: fix error message " Enrico Weigelt, metux IT consult
2019-07-22 12:08 ` Enrico Weigelt, metux IT consult
2019-07-22 12:26 ` Pavel Machek
2019-07-15 14:57 ` [PATCH 6/6] leds: apu: add pr_fmt prefix for better log output Enrico Weigelt, metux IT consult
2019-07-16 19:28 ` Pavel Machek
2019-07-22 20:12 ` leds: apu: drop obsolete support for apu>=2 Jacek Anaszewski
2019-08-29 9:08 ` Enrico Weigelt, metux IT consult
2019-08-29 19:51 ` Jacek Anaszewski
2019-09-24 12:42 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716192805.GE10400@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=info@metux.net \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).