From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] sched/fair: Introduce fits_capacity()
Date: Wed, 17 Jul 2019 16:03:56 +0530 [thread overview]
Message-ID: <20190717103356.gb2guwxy5joko53e@vireshk-i7> (raw)
In-Reply-To: <b477ac75a2b163048bdaeb37f57b4c3f04f75a31.1559631700.git.viresh.kumar@linaro.org>
On 04-06-19, 12:31, Viresh Kumar wrote:
> The same formula to check utilization against capacity (after
> considering capacity_margin) is already used at 5 different locations.
>
> This patch creates a new macro, fits_capacity(), which can be used from
> all these locations without exposing the details of it and hence
> simplify code.
>
> All the 5 code locations are updated as well to use it..
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> kernel/sched/fair.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
@Peter: Do you suggest any modifications to this patch? Do I need to
resend it ?
--
viresh
next prev parent reply other threads:[~2019-07-17 10:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 7:01 [PATCH] sched/fair: Introduce fits_capacity() Viresh Kumar
2019-06-04 15:59 ` Peter Oskolkov
2019-06-06 2:54 ` Viresh Kumar
2019-06-05 9:16 ` Quentin Perret
2019-06-06 2:52 ` Viresh Kumar
2019-06-06 8:12 ` Quentin Perret
2019-06-17 15:02 ` Peter Zijlstra
2019-06-18 3:12 ` Viresh Kumar
2019-06-18 7:26 ` Rafael J. Wysocki
2019-06-18 7:47 ` Viresh Kumar
2019-06-18 8:10 ` Rafael J. Wysocki
2019-06-18 8:25 ` Quentin Perret
2019-06-18 8:36 ` Rafael J. Wysocki
2019-06-18 9:02 ` Quentin Perret
2019-06-18 8:22 ` Quentin Perret
2019-07-17 10:33 ` Viresh Kumar [this message]
2019-07-17 14:59 ` Peter Zijlstra
2019-07-25 16:19 ` [tip:sched/core] " tip-bot for Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717103356.gb2guwxy5joko53e@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).