From: Sam Ravnborg <sam@ravnborg.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Sean Paul <seanpaul@chromium.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/panel: simple: Doxygenize 'struct panel_desc'; rename a few functions
Date: Wed, 17 Jul 2019 19:33:17 +0200 [thread overview]
Message-ID: <20190717173317.GA4862@ravnborg.org> (raw)
In-Reply-To: <20190712163333.231884-1-dianders@chromium.org>
Hi Doug.
On Fri, Jul 12, 2019 at 09:33:33AM -0700, Douglas Anderson wrote:
> This attempts to address outstanding review feedback from commit
> b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical
> timing"). Specifically:
>
> * It was requested that I document (in the structure definition) that
> the device tree override had no effect if 'struct drm_display_mode'
> was used in the panel description. I have provided full Doxygen
> comments for 'struct panel_desc' to accomplish that.
> * panel_simple_get_fixed_modes() was thought to be a confusing name,
> so it has been renamed to panel_simple_get_display_modes().
> * panel_simple_parse_override_mode() was thought to be better named as
> panel_simple_parse_panel_timing_node().
>
> Suggested-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Thanks.
I updated the $subject to:
drm/panel: simple: document panel_desc; rename a few functions
And pushed out to drm-misc-next.
> - Sam said that there was still something that he didn't understand
> with regards to the flags. Sam: if this is something that needs to
> be addressed, please yell.
Need to re-visit this later when I have familiarized myself with
the new yaml syntax and what impact any potential changes may have on
the panel drivers.
So for now we leave it as is.
Sam
next prev parent reply other threads:[~2019-07-17 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 16:33 [PATCH] drm/panel: simple: Doxygenize 'struct panel_desc'; rename a few functions Douglas Anderson
2019-07-17 17:33 ` Sam Ravnborg [this message]
2019-07-21 9:38 ` Sam Ravnborg
2019-07-22 18:26 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717173317.GA4862@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=boris.brezillon@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).