From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC33C7618F for ; Wed, 17 Jul 2019 17:33:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1AC7208C0 for ; Wed, 17 Jul 2019 17:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387768AbfGQRdX (ORCPT ); Wed, 17 Jul 2019 13:33:23 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:59494 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfGQRdX (ORCPT ); Wed, 17 Jul 2019 13:33:23 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 106242002E; Wed, 17 Jul 2019 19:33:18 +0200 (CEST) Date: Wed, 17 Jul 2019 19:33:17 +0200 From: Sam Ravnborg To: Douglas Anderson Cc: Thierry Reding , Sean Paul , Boris Brezillon , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Daniel Vetter Subject: Re: [PATCH] drm/panel: simple: Doxygenize 'struct panel_desc'; rename a few functions Message-ID: <20190717173317.GA4862@ravnborg.org> References: <20190712163333.231884-1-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190712163333.231884-1-dianders@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=cm27Pg_UAAAA:8 a=6j_ga0iaD_65Czu98M8A:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=xmb-EsYY8bH0VWELuYED:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug. On Fri, Jul 12, 2019 at 09:33:33AM -0700, Douglas Anderson wrote: > This attempts to address outstanding review feedback from commit > b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical > timing"). Specifically: > > * It was requested that I document (in the structure definition) that > the device tree override had no effect if 'struct drm_display_mode' > was used in the panel description. I have provided full Doxygen > comments for 'struct panel_desc' to accomplish that. > * panel_simple_get_fixed_modes() was thought to be a confusing name, > so it has been renamed to panel_simple_get_display_modes(). > * panel_simple_parse_override_mode() was thought to be better named as > panel_simple_parse_panel_timing_node(). > > Suggested-by: Sam Ravnborg > Signed-off-by: Douglas Anderson Thanks. I updated the $subject to: drm/panel: simple: document panel_desc; rename a few functions And pushed out to drm-misc-next. > - Sam said that there was still something that he didn't understand > with regards to the flags. Sam: if this is something that needs to > be addressed, please yell. Need to re-visit this later when I have familiarized myself with the new yaml syntax and what impact any potential changes may have on the panel drivers. So for now we leave it as is. Sam