From: Herbert Xu <herbert@gondor.apana.org.au>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
Boqun Feng <boqun.feng@gmail.com>,
"Paul E . McKenney" <paulmck@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mathias Krause <minipli@googlemail.com>
Subject: Re: [PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder
Date: Thu, 18 Jul 2019 22:56:34 +0800 [thread overview]
Message-ID: <20190718145634.xagjemdqpoe44xxh@gondor.apana.org.au> (raw)
In-Reply-To: <20190718142730.uhdkwx5onigdpxno@ca-dmjordan1.us.oracle.com>
On Thu, Jul 18, 2019 at 10:27:30AM -0400, Daniel Jordan wrote:
>
> That's what I expected when I first saw it too, but nr_cpumask_bits is returned
> to signal the end of the iteration. The patch always passes 0 for the 'start'
> argument, so when cpumask_next_wrap is called with the last cpu in the mask,
> the end-of-iteration case is triggered. To reassure you and myself :) I ran it
> and got the expected crash.
>
> Passing pd->cpu for the start argument instead avoids that problem, but the
> one-cpu-in-mask case still needs handling because cpumask_next_wrap always
> signals end of iteration for that, hence the cpumask_weight check.
My bad. I should have set start to -1 to make it do the right thing.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-07-18 14:56 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 22:12 [PATCH] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Daniel Jordan
2019-07-12 10:06 ` Herbert Xu
2019-07-12 10:10 ` Steffen Klassert
2019-07-12 16:07 ` Daniel Jordan
2019-07-13 5:03 ` Herbert Xu
2019-07-15 16:10 ` Daniel Jordan
2019-07-16 10:04 ` Herbert Xu
2019-07-16 11:14 ` Steffen Klassert
2019-07-16 12:57 ` [PATCH] padata: Use RCU when fetching pd from do_serial Herbert Xu
2019-07-16 13:09 ` Herbert Xu
2019-07-16 13:23 ` [v2 PATCH] " Herbert Xu
2019-07-17 8:36 ` Steffen Klassert
2019-07-17 8:50 ` Herbert Xu
2019-07-17 8:28 ` [PATCH] " Steffen Klassert
2019-07-17 8:47 ` Herbert Xu
2019-07-17 8:53 ` Steffen Klassert
2019-07-16 13:15 ` Peter Zijlstra
2019-07-16 13:18 ` Herbert Xu
2019-07-16 13:50 ` Peter Zijlstra
2019-07-16 13:52 ` Herbert Xu
2019-07-16 12:53 ` [PATCH] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Andrea Parri
2019-07-16 13:13 ` Peter Zijlstra
2019-07-16 15:01 ` Herbert Xu
2019-07-16 15:44 ` Daniel Jordan
2019-07-16 16:32 ` [PATCH v2] " Daniel Jordan
2019-07-17 11:11 ` [PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder Herbert Xu
2019-07-17 18:32 ` Daniel Jordan
2019-07-18 3:31 ` Herbert Xu
2019-07-18 14:27 ` Daniel Jordan
2019-07-18 14:56 ` Herbert Xu [this message]
2019-07-18 15:01 ` [v2 PATCH] " Herbert Xu
2019-07-19 14:37 ` Daniel Jordan
2019-07-19 14:55 ` Herbert Xu
2019-07-19 19:04 ` [PATCH] padata: purge get_cpu and reorder_via_wq from padata_do_serial Daniel Jordan
2019-07-26 12:36 ` Herbert Xu
2019-07-19 14:27 ` [PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder Daniel Jordan
2019-07-17 23:21 ` Daniel Jordan
2019-07-18 3:30 ` Herbert Xu
2019-07-18 14:25 ` Daniel Jordan
2019-07-18 14:49 ` Herbert Xu
2019-07-19 14:21 ` Daniel Jordan
2019-07-18 5:42 ` [PATCH v2] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718145634.xagjemdqpoe44xxh@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.m.jordan@oracle.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=paulmck@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).