From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 459E8C76195 for ; Thu, 18 Jul 2019 15:17:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2813B21019 for ; Thu, 18 Jul 2019 15:17:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390637AbfGRPRj (ORCPT ); Thu, 18 Jul 2019 11:17:39 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:43365 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727685AbfGRPRj (ORCPT ); Thu, 18 Jul 2019 11:17:39 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-99.corp.google.com [104.133.0.99] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x6IFHX1a026288 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2019 11:17:34 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 11A92420054; Thu, 18 Jul 2019 11:17:33 -0400 (EDT) Date: Thu, 18 Jul 2019 11:17:33 -0400 From: "Theodore Y. Ts'o" To: Shi Siyuan Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, shisiyuan Subject: Re: [PATCH] ext4: remove unnecessary error check Message-ID: <20190718151732.GA19119@mit.edu> Mail-Followup-To: "Theodore Y. Ts'o" , Shi Siyuan , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, shisiyuan References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 03, 2019 at 04:16:54PM +0800, Shi Siyuan wrote: > From: shisiyuan > > Remove unnecessary error check in ext4_file_write_iter(), > because this check will be done in upcoming later function -- > ext4_write_checks() -> generic_write_checks() > > Change-Id: I7b0ab27f693a50765c15b5eaa3f4e7c38f42e01e > Signed-off-by: shisiyuan Thanks, applied. - Ted