From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F739C76196 for ; Thu, 18 Jul 2019 15:57:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 317E52184B for ; Thu, 18 Jul 2019 15:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563465429; bh=vewp5JqrG7m3ZxgCBMNQmLevnrYi6BZYLDQvIVRpB3Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IWaUvQvRA1VDLRCxeOyOdSFcHtFszgvVDdClw9CyedMIKbHxUGPf7zuXgrVRYOSd1 OjHax1ZbbTQZOV2MXcKCbWjNsNDMstAob6pg8NEC0ZQjRYFDbyE0wS73fQNZ1hQ6ai GdISZuThBQjkE27crJdAwY0i+szqfvyYhd8QIsEw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727955AbfGRP5I (ORCPT ); Thu, 18 Jul 2019 11:57:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:34660 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726040AbfGRP5H (ORCPT ); Thu, 18 Jul 2019 11:57:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 438B1AF6B; Thu, 18 Jul 2019 15:57:06 +0000 (UTC) Date: Thu, 18 Jul 2019 17:57:04 +0200 From: Michal Hocko To: Leonardo Bras Cc: Oscar Salvador , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Mike Rapoport , Pavel Tatashin , =?iso-8859-1?B?Suly9G1l?= Glisse , Thomas Gleixner , Pasha Tatashin , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE Message-ID: <20190718155704.GD30461@dhcp22.suse.cz> References: <20190718024133.3873-1-leonardo@linux.ibm.com> <1563430353.3077.1.camel@suse.de> <0e67afe465cbbdf6ec9b122f596910cae77bc734.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e67afe465cbbdf6ec9b122f596910cae77bc734.camel@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 18-07-19 12:50:29, Leonardo Bras wrote: > On Thu, 2019-07-18 at 08:12 +0200, Oscar Salvador wrote: > > We do already have "movable_node" boot option, which exactly has that > > effect. > > Any hotplugged range will be placed in ZONE_MOVABLE. > Oh, I was not aware of it. > > > Why do we need yet another option to achieve the same? Was not that > > enough for your case? > Well, another use of this config could be doing this boot option a > default on any given kernel. > But in the above case I agree it would be wiser to add the code on > movable_node_is_enabled() directly, and not where I did put. > > What do you think about it? No further config options please. We do have means a more flexible way to achieve movable node onlining so let's use it. Or could you be more specific about cases which cannot use the command line option and really need a config option to workaround that? -- Michal Hocko SUSE Labs