* [PATCH] watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe
@ 2019-07-09 20:34 Nathan Chancellor
2019-07-09 21:00 ` Guenter Roeck
2019-07-18 16:41 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2019-07-09 20:34 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck
Cc: Wolfram Sang, linux-watchdog, linux-kernel, clang-built-linux,
Nathan Chancellor, kernelci . org bot
clang warns:
drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret'
[-Wunused-variable]
int ret;
^
1 warning generated.
It's unused now, remove it.
Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
Link: https://github.com/ClangBuiltLinux/linux/issues/591
Reported-by: kernelci.org bot <bot@kernelci.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/watchdog/digicolor_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
index 33cda95bd238..073d37867f47 100644
--- a/drivers/watchdog/digicolor_wdt.c
+++ b/drivers/watchdog/digicolor_wdt.c
@@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct dc_wdt *wdt;
- int ret;
wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
if (!wdt)
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe
2019-07-09 20:34 [PATCH] watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe Nathan Chancellor
@ 2019-07-09 21:00 ` Guenter Roeck
2019-07-18 16:41 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2019-07-09 21:00 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Wim Van Sebroeck, Wolfram Sang, linux-watchdog, linux-kernel,
clang-built-linux, kernelci . org bot
On Tue, Jul 09, 2019 at 01:34:09PM -0700, Nathan Chancellor wrote:
> clang warns:
>
> drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret'
> [-Wunused-variable]
> int ret;
> ^
> 1 warning generated.
>
> It's unused now, remove it.
>
> Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
> Link: https://github.com/ClangBuiltLinux/linux/issues/591
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/digicolor_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> index 33cda95bd238..073d37867f47 100644
> --- a/drivers/watchdog/digicolor_wdt.c
> +++ b/drivers/watchdog/digicolor_wdt.c
> @@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct dc_wdt *wdt;
> - int ret;
>
> wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
> if (!wdt)
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe
2019-07-09 20:34 [PATCH] watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe Nathan Chancellor
2019-07-09 21:00 ` Guenter Roeck
@ 2019-07-18 16:41 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2019-07-18 16:41 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Wim Van Sebroeck, Guenter Roeck, Wolfram Sang, linux-watchdog,
linux-kernel, clang-built-linux, kernelci . org bot
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
On Tue, Jul 09, 2019 at 01:34:09PM -0700, Nathan Chancellor wrote:
> clang warns:
>
> drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret'
> [-Wunused-variable]
> int ret;
> ^
> 1 warning generated.
>
> It's unused now, remove it.
>
> Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
> Link: https://github.com/ClangBuiltLinux/linux/issues/591
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Oops, sorry for missing this. I wonder why buildbot neither did find
it... Anyway:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-18 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09 20:34 [PATCH] watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe Nathan Chancellor
2019-07-09 21:00 ` Guenter Roeck
2019-07-18 16:41 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).