From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D95CC7618F for ; Thu, 18 Jul 2019 19:59:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B01F208C0 for ; Thu, 18 Jul 2019 19:59:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391417AbfGRT7S (ORCPT ); Thu, 18 Jul 2019 15:59:18 -0400 Received: from gate.crashing.org ([63.228.1.57]:52801 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbfGRT7R (ORCPT ); Thu, 18 Jul 2019 15:59:17 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x6IJwpXD009323; Thu, 18 Jul 2019 14:58:52 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x6IJwou7009319; Thu, 18 Jul 2019 14:58:50 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 18 Jul 2019 14:58:50 -0500 From: Segher Boessenkool To: Alexey Kardashevskiy Cc: Thiago Jung Bauermann , linuxppc-dev@lists.ozlabs.org, Anshuman Khandual , Mike Anderson , Ram Pai , linux-kernel@vger.kernel.org, Claudio Carvalho , Paul Mackerras , Christoph Hellwig Subject: Re: [PATCH v2 03/13] powerpc/prom_init: Add the ESM call to prom_init Message-ID: <20190718195850.GU20882@gate.crashing.org> References: <20190713060023.8479-1-bauerman@linux.ibm.com> <20190713060023.8479-4-bauerman@linux.ibm.com> <70f8097f-7222-fe18-78b4-9372c21bfc9d@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70f8097f-7222-fe18-78b4-9372c21bfc9d@ozlabs.ru> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (Sorry to hijack your reply). On Thu, Jul 18, 2019 at 06:11:48PM +1000, Alexey Kardashevskiy wrote: > On 13/07/2019 16:00, Thiago Jung Bauermann wrote: > >From: Ram Pai > >+static int enter_secure_mode(unsigned long kbase, unsigned long fdt) > >+{ > >+ register uint64_t func asm("r3") = UV_ESM; > >+ register uint64_t arg1 asm("r4") = (uint64_t)kbase; > >+ register uint64_t arg2 asm("r5") = (uint64_t)fdt; > > What does UV do with kbase and fdt precisely? Few words in the commit > log will do. > > >+ > >+ asm volatile("sc 2\n" > >+ : "=r"(func) > >+ : "0"(func), "r"(arg1), "r"(arg2) > >+ :); > >+ > >+ return (int)func; > > And why "func"? Is it "function"? Weird name. Thanks, Maybe the three vars should just be called "r3", "r4", and "r5" -- r3 is used as return value as well, so "func" isn't a great name for it. Some other comments about this inline asm: The "\n" makes the generated asm look funny and has no other function. Instead of using backreferences you can use a "+" constraint, "inout". Empty clobber list is strange. Casts to the return type, like most other casts, are an invitation to bugs and not actually useful. So this can be written static int enter_secure_mode(unsigned long kbase, unsigned long fdt) { register uint64_t r3 asm("r3") = UV_ESM; register uint64_t r4 asm("r4") = kbase; register uint64_t r4 asm("r5") = fdt; asm volatile("sc 2" : "+r"(r3) : "r"(r4), "r"(r5)); return r3; } (and it probably should use u64 instead of both uint64_t and unsigned long?) Segher