linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Vaibhav Rustagi <vaibhavrustagi@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Vivek Goyal <vgoyal@redhat.com>,
	"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86/purgatory: add -mno-sse, -mno-mmx, -mno-sse2 to Makefile
Date: Fri, 19 Jul 2019 10:17:32 +0200	[thread overview]
Message-ID: <20190719081732.GF3419@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKwvOdkHHNR7utufOcDwAOgBEA9MnOLh713Gaq01R=n26EyjZw@mail.gmail.com>

On Thu, Jul 18, 2019 at 02:34:44PM -0700, Nick Desaulniers wrote:
> On Wed, Jul 17, 2019 at 5:02 PM Vaibhav Rustagi
> <vaibhavrustagi@google.com> wrote:
> >
> > Compiling the purgatory code with clang results in using of mmx
> > registers.
> >
> > $ objdump -d arch/x86/purgatory/purgatory.ro | grep xmm
> >
> >      112:       0f 28 00                movaps (%rax),%xmm0
> >      115:       0f 11 07                movups %xmm0,(%rdi)
> >      122:       0f 28 00                movaps (%rax),%xmm0
> >      125:       0f 11 47 10             movups %xmm0,0x10(%rdi)
> >
> > Add -mno-sse, -mno-mmx, -mno-sse2 to avoid generating SSE instructions.
> >
> > Signed-off-by: Vaibhav Rustagi <vaibhavrustagi@google.com>
> > ---
> >  arch/x86/purgatory/Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
> > index 3cf302b26332..3589ec4a28c7 100644
> > --- a/arch/x86/purgatory/Makefile
> > +++ b/arch/x86/purgatory/Makefile
> > @@ -20,6 +20,7 @@ KCOV_INSTRUMENT := n
> >  # sure how to relocate those. Like kexec-tools, use custom flags.
> >
> >  KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes -fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -Os -mcmodel=large
> > +KBUILD_CFLAGS += -mno-mmx -mno-sse -mno-sse2
> 
> Yep, this is a commonly recurring bug in the kernel, observed again
> and again for Clang builds.  The top level Makefile carefully sets
> KBUILD_CFLAGS, then lower subdirs in the kernel wipe them away with
> `:=` assignment. Invariably important flags don't always get re-added.
> In this case, these flags are used in arch/x86/Makefile, but not here
> and should be IMO.  Thanks for the patch.

Should we then not fix/remove these := assignments?

  reply	other threads:[~2019-07-19  8:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18  0:02 [PATCH 0/2] Support kexec/kdump for clang built kernel Vaibhav Rustagi
2019-07-18  0:02 ` [PATCH 1/2] x86/purgatory: add -mno-sse, -mno-mmx, -mno-sse2 to Makefile Vaibhav Rustagi
2019-07-18  0:47   ` Greg KH
2019-07-18 21:34   ` Nick Desaulniers
2019-07-19  8:17     ` Peter Zijlstra [this message]
2019-07-22 21:12       ` Nick Desaulniers
2019-07-18  0:02 ` [PATCH 2/2] x86/purgatory: do not use __builtin_memcpy and __builtin_memset Vaibhav Rustagi
2019-07-18  0:47   ` Greg KH
2019-07-18 21:56   ` Nick Desaulniers
2019-07-18 21:29 ` [PATCH 0/2] Support kexec/kdump for clang built kernel Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190719081732.GF3419@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=ndesaulniers@google.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vaibhavrustagi@google.com \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).