From: Al Viro <viro@zeniv.linux.org.uk>
To: Jeff Layton <jlayton@kernel.org>
Cc: Luis Henriques <lhenriques@suse.com>,
Ilya Dryomov <idryomov@gmail.com>, Sage Weil <sage@redhat.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr()
Date: Sat, 20 Jul 2019 00:23:08 +0100 [thread overview]
Message-ID: <20190719232307.GA17978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1dee14212043f12ef5b26e4aee0c3155e118abf3.camel@kernel.org>
On Fri, Jul 19, 2019 at 07:07:49PM -0400, Jeff Layton wrote:
> Al pointed out on IRC that vfree should be callable under spinlock.
Al had been near-terminally low on caffeine at the time, posted
a retraction a few minutes later and went to grab some coffee...
> It
> only sleeps if !in_interrupt(), and I think that should return true if
> we're holding a spinlock.
It can be used from RCU callbacks and all such; it *can't* be used from
under spinlock - on non-preempt builds there's no way to recognize that.
next prev parent reply other threads:[~2019-07-19 23:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 14:32 [PATCH 0/4] Sleeping functions in invalid context bug fixes Luis Henriques
2019-07-19 14:32 ` [PATCH 1/4] libceph: allow ceph_buffer_put() to receive a NULL ceph_buffer Luis Henriques
2019-07-19 14:32 ` [PATCH 2/4] ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr() Luis Henriques
2019-07-19 23:07 ` Jeff Layton
2019-07-19 23:23 ` Al Viro [this message]
2019-07-19 23:30 ` Al Viro
2019-07-20 0:35 ` Jeff Layton
2019-07-19 14:32 ` [PATCH 3/4] ceph: fix buffer free while holding i_ceph_lock in __ceph_build_xattrs_blob() Luis Henriques
2019-07-19 14:32 ` [PATCH 4/4] ceph: fix buffer free while holding i_ceph_lock in fill_inode() Luis Henriques
2019-07-19 15:20 ` [PATCH 0/4] Sleeping functions in invalid context bug fixes Jeff Layton
2019-07-23 10:02 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719232307.GA17978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=lhenriques@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).