From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
To: Bob Copeland <me@bobcopeland.com>,
linux-karma-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH] fs/omfs: make use of kmemdup
Date: Sun, 21 Jul 2019 16:53:27 +0530 [thread overview]
Message-ID: <20190721112326.GA5927@hari-Inspiron-1545> (raw)
kmalloc + memcpy can be replaced with kmemdup.
fix below issue reported by coccicheck
./fs/omfs/inode.c:366:9-16: WARNING opportunity for kmemdup
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
fs/omfs/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index 08226a8..bc5a072 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb)
bh = sb_bread(sb, block++);
if (!bh)
goto nomem_free;
- *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
+ *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
if (!*ptr) {
brelse(bh);
goto nomem_free;
}
- memcpy(*ptr, bh->b_data, sb->s_blocksize);
if (count < sb->s_blocksize)
memset((void *)*ptr + count, 0xff,
sb->s_blocksize - count);
--
2.7.4
next reply other threads:[~2019-07-21 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 11:23 Hariprasad Kelam [this message]
2019-07-22 13:15 ` [PATCH] fs/omfs: make use of kmemdup Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190721112326.GA5927@hari-Inspiron-1545 \
--to=hariprasad.kelam@gmail.com \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).