* [PATCH] fs/omfs: make use of kmemdup
@ 2019-07-21 11:23 Hariprasad Kelam
2019-07-22 13:15 ` Bob Copeland
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-07-21 11:23 UTC (permalink / raw)
To: Bob Copeland, linux-karma-devel, linux-kernel
kmalloc + memcpy can be replaced with kmemdup.
fix below issue reported by coccicheck
./fs/omfs/inode.c:366:9-16: WARNING opportunity for kmemdup
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
fs/omfs/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index 08226a8..bc5a072 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb)
bh = sb_bread(sb, block++);
if (!bh)
goto nomem_free;
- *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
+ *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
if (!*ptr) {
brelse(bh);
goto nomem_free;
}
- memcpy(*ptr, bh->b_data, sb->s_blocksize);
if (count < sb->s_blocksize)
memset((void *)*ptr + count, 0xff,
sb->s_blocksize - count);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/omfs: make use of kmemdup
2019-07-21 11:23 [PATCH] fs/omfs: make use of kmemdup Hariprasad Kelam
@ 2019-07-22 13:15 ` Bob Copeland
0 siblings, 0 replies; 2+ messages in thread
From: Bob Copeland @ 2019-07-22 13:15 UTC (permalink / raw)
To: Hariprasad Kelam; +Cc: linux-karma-devel, linux-kernel
On Sun, Jul 21, 2019 at 04:53:27PM +0530, Hariprasad Kelam wrote:
> kmalloc + memcpy can be replaced with kmemdup.
>
> fix below issue reported by coccicheck
> ./fs/omfs/inode.c:366:9-16: WARNING opportunity for kmemdup
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Thanks!
Acked-by: Bob Copeland <me@bobcopeland.com>
--
Bob Copeland %% https://bobcopeland.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-22 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-21 11:23 [PATCH] fs/omfs: make use of kmemdup Hariprasad Kelam
2019-07-22 13:15 ` Bob Copeland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).