From: Eiichi Tsukata <devel@etsukata.com>
To: mhiramat@kernel.org
Cc: juri.lelli@gmail.com, linux-kernel@vger.kernel.org,
mingo@kernel.org, peterz@infradead.org, rostedt@goodmis.org,
tglx@linutronix.de, torvalds@linux-foundation.org,
williams@redhat.com, Eiichi Tsukata <devel@etsukata.com>
Subject: [PATCH 0/1] x86/stacktrace: Fix userstacktrace access_ok() WARNING in irq events
Date: Mon, 22 Jul 2019 17:32:15 +0900 [thread overview]
Message-ID: <20190722083216.16192-1-devel@etsukata.com> (raw)
In-Reply-To: <20190621231232.259536faeea4b19cf39a7688@kernel.org>
Hello
I also hit the same WARNING previously repored by Juri.
Hiramatsu san's patch looks good to me but I found that perf and
oprofile code do the similar thing by just directly calling
__range_not_ok().
perf: perf_callchain_user()@arch/x86/events/core.c
oprofile: dump_user_backtrace()@arch/x86/oprofile/backtrace.c
So for simplicity, I wrote a patch to fix the warning as other
codes do.
Ideally, we should merge these similar stacktrace codes(perf, ftrace,
oprofile) into one, but this time I made the minimum fix.
Eiichi Tsukata (1):
x86/stacktrace: Fix userstacktrace access_ok() WARNING in irq events
arch/x86/kernel/stacktrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.21.0
next prev parent reply other threads:[~2019-07-22 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 16:16 WARN_ON: userstacktrace on irq events Steven Rostedt
2019-04-05 8:12 ` Thomas Gleixner
2019-04-05 13:32 ` Steven Rostedt
2019-06-21 14:12 ` Masami Hiramatsu
2019-07-22 8:32 ` Eiichi Tsukata [this message]
2019-07-22 8:32 ` [PATCH 1/1] x86/stacktrace: Fix userstacktrace access_ok() WARNING in " Eiichi Tsukata
2019-07-22 8:46 ` [tip:x86/urgent] x86/stacktrace: Prevent access_ok() warnings in arch_stack_walk_user() tip-bot for Eiichi Tsukata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722083216.16192-1-devel@etsukata.com \
--to=devel@etsukata.com \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).