From: Rob Herring <robh@kernel.org>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: miquel.raynal@bootlin.com, marek.vasut@gmail.com,
bbrezillon@kernel.org, dwmw2@infradead.org,
computersforpeace@gmail.com, vigneshr@ti.com, richard@nod.at,
stefan@agner.ch, mark.rutland@arm.com,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
juliensu@mxic.com.tw, paul.burton@mips.com,
liang.yang@amlogic.com, lee.jones@linaro.org,
anders.roxell@linaro.org, christophe.kerello@st.com,
paul@crapouillou.net, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings
Date: Mon, 22 Jul 2019 17:46:14 -0600 [thread overview]
Message-ID: <20190722234614.GA11971@bogus> (raw)
In-Reply-To: <1562138144-2212-3-git-send-email-masonccyang@mxic.com.tw>
On Wed, Jul 03, 2019 at 03:15:44PM +0800, Mason Yang wrote:
> Document the bindings used by the Macronix raw NAND controller.
>
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> ---
> Documentation/devicetree/bindings/mtd/mxic-nand.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/mxic-nand.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/mxic-nand.txt b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> new file mode 100644
> index 0000000..ddd7660
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> @@ -0,0 +1,20 @@
> +Macronix Raw NAND Controller Device Tree Bindings
> +-------------------------------------------------
> +
> +Required properties:
> +- compatible: should be "macronix,nand-controller"
That's not very specific. There's only 1 version of this h/w?
> +- reg: should contain 1 entrie for the registers
s/entrie/entry/
> +- interrupts: interrupt line connected to this raw NAND controller
> +- clock-names: should contain "ps_clk", "send_clk" and "send_dly_clk"
> +- clocks: should contain 3 phandles for the "ps_clk", "send_clk" and
> + "send_dly_clk" clocks
You can drop '_clk' as that is redundant.
> +
> +Example:
> +
> + nand: mxic-nfc@43c30000 {
> + compatible = "macronix,nand-controller";
> + reg = <0x43c30000 0x10000>;
> + reg-names = "regs";
Not documented. You can drop as *-names is not generally useful when
there is only 1 entry.
> + clocks = <&clkwizard 0>, <&clkwizard 1>, <&clkc 15>;
> + clock-names = "send_clk", "send_dly_clk", "ps_clk";
> + };
> --
> 1.9.1
>
next prev parent reply other threads:[~2019-07-22 23:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 7:15 [PATCH v5 0/2] Add Macronix raw NAND controller driver Mason Yang
2019-07-03 7:15 ` [PATCH v5 1/2] mtd: rawnand: Add Macronix raw NAND controller Mason Yang
2019-07-03 7:15 ` [PATCH v5 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings Mason Yang
2019-07-04 8:29 ` Sergei Shtylyov
2019-07-18 0:59 ` masonccyang
2019-07-22 23:46 ` Rob Herring [this message]
2019-07-23 3:26 ` masonccyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722234614.GA11971@bogus \
--to=robh@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=bbrezillon@kernel.org \
--cc=christophe.kerello@st.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=juliensu@mxic.com.tw \
--cc=lee.jones@linaro.org \
--cc=liang.yang@amlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).