From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A83DC76195 for ; Tue, 23 Jul 2019 01:56:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19225223A1 for ; Tue, 23 Jul 2019 01:56:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="cgn8c/EV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732129AbfGWB4i (ORCPT ); Mon, 22 Jul 2019 21:56:38 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57822 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727851AbfGWB4i (ORCPT ); Mon, 22 Jul 2019 21:56:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3UPS6SnYVearlAWk6p3v30CJre0DZAAwQz9HmajYiJE=; b=cgn8c/EVPnhqqkTTKzJUTz8wH8 zy+TZ0cFEj/uUyajGn9DuybbZeGoHdsRrI31SQOlsQaKyel8/mVddkZKIFWAwzhvOgj3cGNMYtCW+ Ds11XZyT39fGEMdnjrAr5dMtFVwWB6PKcdR9ssXQsFwUge/zRukl81/256xZ2kQtxmEs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hpk2Z-0006U1-NM; Tue, 23 Jul 2019 03:56:31 +0200 Date: Tue, 23 Jul 2019 03:56:31 +0200 From: Andrew Lunn To: Evgeny Kolesnikov Cc: Mark Rutland , Jason Cooper , linux-pm@vger.kernel.org, Gregory Clement , Sebastian Reichel , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Subject: Re: [PATCH 0/5] Add support for WD MyCloud EX2 Ultra (+ versatile UART-based restart/poweroff drivers) Message-ID: <20190723015631.GI8972@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 22, 2019 at 09:53:00PM +0200, Evgeny Kolesnikov wrote: > This patchset consists of the DTS, which describes the WD MyCloud EX2 Ultra device, > 'poweroff' and 'resert' drivers for power-managing MCUs connected to a board via UART > (these drivers are more versatile than qnap-poweroff and could be used as a substitude), > and DT bindings for these drivers. > > The difference between uart-poweroff and qnap-poweroff is small, but important: > uart-poweroff is able to send to an MCU a command of arbitrary length, and the command > itself is defined in a DTS file for a specific device/board, thus making this driver > applicable to wider range of devices. Hi Evgeny There is a lot of replicated code here, and in the original qnap-poweroff.c driver. Please consolidate it by extending the current driver. It should be easy to add a new compatible string, and turn power_off_cfg.cmd into an array. Andrew