* [PATCH] RDMA/hns: Fix build error for hip06
@ 2019-07-23 2:45 YueHaibing
2019-07-24 3:44 ` [PATCH v2] " YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-07-23 2:45 UTC (permalink / raw)
To: oulijun, xavier.huwei, dledford, jgg; +Cc: linux-kernel, linux-rdma, YueHaibing
If INFINIBAND_HNS_HIP06 is selected and HNS_DSAF
is m, but INFINIBAND_HNS is y, building fails:
drivers/infiniband/hw/hns/hns_roce_hw_v1.o: In function `hns_roce_v1_reset':
hns_roce_hw_v1.c:(.text+0x39fa): undefined reference to `hns_dsaf_roce_reset'
hns_roce_hw_v1.c:(.text+0x3a25): undefined reference to `hns_dsaf_roce_reset'
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 08805fdbeb2d ("RDMA/hns: Split hw v1 driver from hns roce driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/infiniband/hw/hns/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig
index 8bf847b..b59da5d 100644
--- a/drivers/infiniband/hw/hns/Kconfig
+++ b/drivers/infiniband/hw/hns/Kconfig
@@ -12,7 +12,8 @@ config INFINIBAND_HNS
config INFINIBAND_HNS_HIP06
bool "Hisilicon Hip06 Family RoCE support"
- depends on INFINIBAND_HNS && HNS && HNS_DSAF && HNS_ENET
+ depends on INFINIBAND_HNS && HNS && (INFINIBAND_HNS = HNS_DSAF)
+ depends on HNS_ENET
---help---
RoCE driver support for Hisilicon RoCE engine in Hisilicon Hip06 and
Hip07 SoC. These RoCE engines are platform devices.
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] RDMA/hns: Fix build error for hip06
2019-07-23 2:45 [PATCH] RDMA/hns: Fix build error for hip06 YueHaibing
@ 2019-07-24 3:44 ` YueHaibing
2019-07-24 3:58 ` Yuehaibing
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-07-24 3:44 UTC (permalink / raw)
To: oulijun, xavier.huwei, dledford, jgg, leon
Cc: linux-kernel, linux-rdma, YueHaibing
If INFINIBAND_HNS_HIP06 is selected and HNS_DSAF
is m, but INFINIBAND_HNS is y, building fails:
drivers/infiniband/hw/hns/hns_roce_hw_v1.o: In function `hns_roce_v1_reset':
hns_roce_hw_v1.c:(.text+0x39fa): undefined reference to `hns_dsaf_roce_reset'
hns_roce_hw_v1.c:(.text+0x3a25): undefined reference to `hns_dsaf_roce_reset'
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 08805fdbeb2d ("RDMA/hns: Split hw v1 driver from hns roce driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: use select instead of depends
---
drivers/infiniband/hw/hns/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig
index b9dfac0..5f6d750 100644
--- a/drivers/infiniband/hw/hns/Kconfig
+++ b/drivers/infiniband/hw/hns/Kconfig
@@ -12,7 +12,8 @@ config INFINIBAND_HNS
config INFINIBAND_HNS_HIP06
bool "Hisilicon Hip06 Family RoCE support"
- depends on INFINIBAND_HNS && HNS && HNS_DSAF && HNS_ENET
+ depends on INFINIBAND_HNS && HNS && HNS_ENET
+ select HNS_DSAF
---help---
RoCE driver support for Hisilicon RoCE engine in Hisilicon Hip06 and
Hip07 SoC. These RoCE engines are platform devices.
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] RDMA/hns: Fix build error for hip06
2019-07-24 3:44 ` [PATCH v2] " YueHaibing
@ 2019-07-24 3:58 ` Yuehaibing
0 siblings, 0 replies; 3+ messages in thread
From: Yuehaibing @ 2019-07-24 3:58 UTC (permalink / raw)
To: oulijun, xavier.huwei, dledford, jgg, leon; +Cc: linux-kernel, linux-rdma
Pls ignore this, I will fix it.
On 2019/7/24 11:44, YueHaibing wrote:
> If INFINIBAND_HNS_HIP06 is selected and HNS_DSAF
> is m, but INFINIBAND_HNS is y, building fails:
>
> drivers/infiniband/hw/hns/hns_roce_hw_v1.o: In function `hns_roce_v1_reset':
> hns_roce_hw_v1.c:(.text+0x39fa): undefined reference to `hns_dsaf_roce_reset'
> hns_roce_hw_v1.c:(.text+0x3a25): undefined reference to `hns_dsaf_roce_reset'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 08805fdbeb2d ("RDMA/hns: Split hw v1 driver from hns roce driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: use select instead of depends
> ---
> drivers/infiniband/hw/hns/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig
> index b9dfac0..5f6d750 100644
> --- a/drivers/infiniband/hw/hns/Kconfig
> +++ b/drivers/infiniband/hw/hns/Kconfig
> @@ -12,7 +12,8 @@ config INFINIBAND_HNS
>
> config INFINIBAND_HNS_HIP06
> bool "Hisilicon Hip06 Family RoCE support"
> - depends on INFINIBAND_HNS && HNS && HNS_DSAF && HNS_ENET
> + depends on INFINIBAND_HNS && HNS && HNS_ENET
> + select HNS_DSAF
> ---help---
> RoCE driver support for Hisilicon RoCE engine in Hisilicon Hip06 and
> Hip07 SoC. These RoCE engines are platform devices.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-24 3:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 2:45 [PATCH] RDMA/hns: Fix build error for hip06 YueHaibing
2019-07-24 3:44 ` [PATCH v2] " YueHaibing
2019-07-24 3:58 ` Yuehaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).