* [PATCH] clk: imx: imx8mm: fix audio pll setting
@ 2019-07-15 2:55 Peng Fan
2019-07-15 7:27 ` Abel Vesa
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Peng Fan @ 2019-07-15 2:55 UTC (permalink / raw)
To: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam
Cc: dl-linux-imx, Leonard Crestez, Anson Huang, Jacky Bai, linux-clk,
linux-arm-kernel, linux-kernel, van.freenix, Peng Fan, stable
From: Peng Fan <peng.fan@nxp.com>
The AUDIO PLL max support 650M, so the original clk settings violate
spec. This patch makes the output 786432000 -> 393216000,
and 722534400 -> 361267200 to aligned with NXP vendor kernel without any
impact on audio functionality and go within 650MHz PLL limit.
Cc: <stable@vger.kernel.org>
Fixes: ba5625c3e272 ("clk: imx: Add clock driver support for imx8mm")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/clk/imx/clk-imx8mm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index 3a873e0e278f..b72bad064d8d 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -55,8 +55,8 @@ static const struct imx_pll14xx_rate_table imx8mm_pll1416x_tbl[] = {
};
static const struct imx_pll14xx_rate_table imx8mm_audiopll_tbl[] = {
- PLL_1443X_RATE(786432000U, 655, 5, 2, 23593),
- PLL_1443X_RATE(722534400U, 301, 5, 1, 3670),
+ PLL_1443X_RATE(393216000U, 262, 2, 3, 9437),
+ PLL_1443X_RATE(361267200U, 361, 3, 3, 17511),
};
static const struct imx_pll14xx_rate_table imx8mm_videopll_tbl[] = {
--
2.16.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: imx: imx8mm: fix audio pll setting
2019-07-15 2:55 [PATCH] clk: imx: imx8mm: fix audio pll setting Peng Fan
@ 2019-07-15 7:27 ` Abel Vesa
2019-07-22 22:06 ` Stephen Boyd
2019-07-23 6:21 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2019-07-15 7:27 UTC (permalink / raw)
To: Peng Fan
Cc: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam,
dl-linux-imx, Leonard Crestez, Anson Huang, Jacky Bai, linux-clk,
linux-arm-kernel, linux-kernel, van.freenix, stable
On 19-07-15 02:55:43, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> The AUDIO PLL max support 650M, so the original clk settings violate
> spec. This patch makes the output 786432000 -> 393216000,
> and 722534400 -> 361267200 to aligned with NXP vendor kernel without any
> impact on audio functionality and go within 650MHz PLL limit.
>
> Cc: <stable@vger.kernel.org>
> Fixes: ba5625c3e272 ("clk: imx: Add clock driver support for imx8mm")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> drivers/clk/imx/clk-imx8mm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index 3a873e0e278f..b72bad064d8d 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -55,8 +55,8 @@ static const struct imx_pll14xx_rate_table imx8mm_pll1416x_tbl[] = {
> };
>
> static const struct imx_pll14xx_rate_table imx8mm_audiopll_tbl[] = {
> - PLL_1443X_RATE(786432000U, 655, 5, 2, 23593),
> - PLL_1443X_RATE(722534400U, 301, 5, 1, 3670),
> + PLL_1443X_RATE(393216000U, 262, 2, 3, 9437),
> + PLL_1443X_RATE(361267200U, 361, 3, 3, 17511),
> };
>
> static const struct imx_pll14xx_rate_table imx8mm_videopll_tbl[] = {
> --
> 2.16.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: imx: imx8mm: fix audio pll setting
2019-07-15 2:55 [PATCH] clk: imx: imx8mm: fix audio pll setting Peng Fan
2019-07-15 7:27 ` Abel Vesa
@ 2019-07-22 22:06 ` Stephen Boyd
2019-07-23 0:56 ` Peng Fan
2019-07-23 6:21 ` Shawn Guo
2 siblings, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2019-07-22 22:06 UTC (permalink / raw)
To: festevam, kernel, mturquette, s.hauer, shawnguo, Peng Fan
Cc: dl-linux-imx, Leonard Crestez, Anson Huang, Jacky Bai, linux-clk,
linux-arm-kernel, linux-kernel, van.freenix, Peng Fan, stable
Quoting Peng Fan (2019-07-14 19:55:43)
> From: Peng Fan <peng.fan@nxp.com>
>
> The AUDIO PLL max support 650M, so the original clk settings violate
> spec. This patch makes the output 786432000 -> 393216000,
> and 722534400 -> 361267200 to aligned with NXP vendor kernel without any
> impact on audio functionality and go within 650MHz PLL limit.
>
> Cc: <stable@vger.kernel.org>
> Fixes: ba5625c3e272 ("clk: imx: Add clock driver support for imx8mm")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
Is this a problem right now, i.e. should I apply this to clk-fixes? Or
can this wait until next merge window?
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] clk: imx: imx8mm: fix audio pll setting
2019-07-22 22:06 ` Stephen Boyd
@ 2019-07-23 0:56 ` Peng Fan
0 siblings, 0 replies; 5+ messages in thread
From: Peng Fan @ 2019-07-23 0:56 UTC (permalink / raw)
To: Stephen Boyd, festevam, kernel, mturquette, s.hauer, shawnguo
Cc: dl-linux-imx, Leonard Crestez, Anson Huang, Jacky Bai, linux-clk,
linux-arm-kernel, linux-kernel, van.freenix, stable
Hi Stephen,
> Subject: Re: [PATCH] clk: imx: imx8mm: fix audio pll setting
>
> Quoting Peng Fan (2019-07-14 19:55:43)
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The AUDIO PLL max support 650M, so the original clk settings violate
> > spec. This patch makes the output 786432000 -> 393216000, and
> > 722534400 -> 361267200 to aligned with NXP vendor kernel without any
> > impact on audio functionality and go within 650MHz PLL limit.
> >
> > Cc: <stable@vger.kernel.org>
> > Fixes: ba5625c3e272 ("clk: imx: Add clock driver support for imx8mm")
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
>
> Is this a problem right now, i.e. should I apply this to clk-fixes? Or can this wait
> until next merge window?
Could wait until next merge window.
Thanks,
Peng.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: imx: imx8mm: fix audio pll setting
2019-07-15 2:55 [PATCH] clk: imx: imx8mm: fix audio pll setting Peng Fan
2019-07-15 7:27 ` Abel Vesa
2019-07-22 22:06 ` Stephen Boyd
@ 2019-07-23 6:21 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-07-23 6:21 UTC (permalink / raw)
To: Peng Fan
Cc: mturquette, sboyd, s.hauer, kernel, festevam, dl-linux-imx,
Leonard Crestez, Anson Huang, Jacky Bai, linux-clk,
linux-arm-kernel, linux-kernel, van.freenix, stable
On Mon, Jul 15, 2019 at 02:55:43AM +0000, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> The AUDIO PLL max support 650M, so the original clk settings violate
> spec. This patch makes the output 786432000 -> 393216000,
> and 722534400 -> 361267200 to aligned with NXP vendor kernel without any
> impact on audio functionality and go within 650MHz PLL limit.
>
> Cc: <stable@vger.kernel.org>
> Fixes: ba5625c3e272 ("clk: imx: Add clock driver support for imx8mm")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-23 6:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15 2:55 [PATCH] clk: imx: imx8mm: fix audio pll setting Peng Fan
2019-07-15 7:27 ` Abel Vesa
2019-07-22 22:06 ` Stephen Boyd
2019-07-23 0:56 ` Peng Fan
2019-07-23 6:21 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).