From: Leon Romanovsky <leon@kernel.org>
To: Yuehaibing <yuehaibing@huawei.com>
Cc: oulijun@huawei.com, xavier.huwei@huawei.com, dledford@redhat.com,
jgg@ziepe.ca, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/hns: Fix build error for hip08
Date: Tue, 23 Jul 2019 13:17:44 +0300 [thread overview]
Message-ID: <20190723101744.GL5125@mtr-leonro.mtl.com> (raw)
In-Reply-To: <dd405aec-17ca-4ac4-9620-f28f7758022c@huawei.com>
On Tue, Jul 23, 2019 at 06:06:22PM +0800, Yuehaibing wrote:
>
> On 2019/7/23 15:43, Leon Romanovsky wrote:
> > On Tue, Jul 23, 2019 at 10:49:08AM +0800, YueHaibing wrote:
> >> If INFINIBAND_HNS_HIP08 is selected and HNS3 is m,
> >> but INFINIBAND_HNS is y, building fails:
> >>
> >> drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_exit':
> >> hns_roce_hw_v2.c:(.exit.text+0xd): undefined reference to `hnae3_unregister_client'
> >> drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_init':
> >> hns_roce_hw_v2.c:(.init.text+0xd): undefined reference to `hnae3_register_client'
> >
> > It means that you have a problem with header files of your hns3.
>
> hnae3_unregister_client is a EXPORT_SYMBOL. If INFINIBAND_HNS is y,
> hns-roce-hw-v2 will be built-in, but as HNS3 is set to m, linking will failed.
One of the possible solution is to add "select" identifier to your
Kconfig, it will ensure that HNS3 will be set to "y" too.
Thanks
next prev parent reply other threads:[~2019-07-23 10:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 2:49 [PATCH] RDMA/hns: Fix build error for hip08 YueHaibing
2019-07-23 7:43 ` Leon Romanovsky
2019-07-23 10:06 ` Yuehaibing
2019-07-23 10:17 ` Leon Romanovsky [this message]
2019-07-23 12:34 ` Jason Gunthorpe
2019-07-23 13:35 ` Leon Romanovsky
2019-07-23 13:37 ` Jason Gunthorpe
2019-07-24 3:10 ` Yuehaibing
2019-07-24 3:40 ` [PATCH v2] " YueHaibing
2019-07-24 6:12 ` Yuehaibing
2019-07-24 6:54 ` [PATCH] RDMA/hns: Fix build error YueHaibing
2019-07-24 11:32 ` Jason Gunthorpe
2019-07-24 11:47 ` Yuehaibing
2019-07-29 16:05 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723101744.GL5125@mtr-leonro.mtl.com \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=xavier.huwei@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).