From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 833A5C7618B for ; Tue, 23 Jul 2019 14:51:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 620D3218B8 for ; Tue, 23 Jul 2019 14:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390766AbfGWOvH (ORCPT ); Tue, 23 Jul 2019 10:51:07 -0400 Received: from muru.com ([72.249.23.125]:55730 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388251AbfGWOvE (ORCPT ); Tue, 23 Jul 2019 10:51:04 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 82FC2808C; Tue, 23 Jul 2019 14:51:28 +0000 (UTC) Date: Tue, 23 Jul 2019 07:51:00 -0700 From: Tony Lindgren To: David Lechner Cc: linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , William Breathitt Gray , Thierry Reding , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH 3/4] ARM: dts: am33xx: Add nodes for eQEP Message-ID: <20190723145100.GS5447@atomide.com> References: <20190722154538.5314-1-david@lechnology.com> <20190722154538.5314-4-david@lechnology.com> <20190723084213.GR5447@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * David Lechner [190723 14:46]: > On 7/23/19 3:42 AM, Tony Lindgren wrote: > > * David Lechner [190722 15:46]: > > > This adds new nodes for the Texas Instruments Enhanced Quadrature > > > Encoder Pulse (eQEP) module in the PWM subsystem on AM33XX. > > > > > > Signed-off-by: David Lechner > > > --- > > > arch/arm/boot/dts/am33xx-l4.dtsi | 27 +++++++++++++++++++++++++++ > > > 1 file changed, 27 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi > > > index 3b1fb2ba4dff..7fdc2f61c553 100644 > > > --- a/arch/arm/boot/dts/am33xx-l4.dtsi > > > +++ b/arch/arm/boot/dts/am33xx-l4.dtsi > > > @@ -1908,6 +1908,15 @@ > > > status = "disabled"; > > > }; > > > + eqep0: eqep@180 { > > > + compatible = "ti,am3352-eqep"; > > > + reg = <0x180 0x80>; > > > + clocks = <&l4ls_gclk>; > > > + clock-names = "fck"; > > > + interrupts = <79>; > > > + status = "disabled"; > > > + }; > > > + > > > > You probably no longer need to map any clocks here as this> is now a child of the interconnect target module managed > > by ti-sysc driver. I have not checked but probably l4ls_gclk > > is same as clocks = <&l4ls_clkctrl AM3_L4LS_EPWMSS0_CLKCTRL 0> > > already managed by ti-sysc. If so, then just using runtime PM > > calls in any of the child device drivers will keep it enabled. > > > > If l4ls_gclk is a separate functional clock, then it still > > needs to be managed by the child device driver directly. > > The clock is included so that we can get the clock rate for > the timing aspects of the eQEP, not for power management. > > I chose to use the "fck" name to be consistent with the > sibling EHRPWM and ECAP nodes that already have the same > bindings for the same clock. OK makes sense to me thanks. Tony