From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: kishon@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Add of_node_put() before return
Date: Tue, 23 Jul 2019 16:08:18 +0200 [thread overview]
Message-ID: <20190723160818.2bf7eb80@xps13> (raw)
In-Reply-To: <20190723105108.8306-1-nishkadg.linux@gmail.com>
Hi Nishka,
Nishka Dasgupta <nishkadg.linux@gmail.com> wrote on Tue, 23 Jul 2019
16:21:08 +0530:
> Each iteration of for_each_available_child_of_node puts the previous
> node, but in the case of a return from the middle of the loop, there is
> no put, thus causing a memory leak. Hence add an of_node_put before the
> return in two places.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/marvell/phy-mvebu-a3700-comphy.c b/drivers/phy/marvell/phy-mvebu-a3700-comphy.c
> index 8812a104c233..0ebac46435bd 100644
> --- a/drivers/phy/marvell/phy-mvebu-a3700-comphy.c
> +++ b/drivers/phy/marvell/phy-mvebu-a3700-comphy.c
> @@ -277,13 +277,17 @@ static int mvebu_a3700_comphy_probe(struct platform_device *pdev)
> }
>
> lane = devm_kzalloc(&pdev->dev, sizeof(*lane), GFP_KERNEL);
> - if (!lane)
> + if (!lane) {
> + of_node_put(child);
> return -ENOMEM;
> + }
>
> phy = devm_phy_create(&pdev->dev, child,
> &mvebu_a3700_comphy_ops);
> - if (IS_ERR(phy))
> + if (IS_ERR(phy)) {
> + of_node_put(child);
> return PTR_ERR(phy);
> + }
>
> lane->dev = &pdev->dev;
> lane->mode = PHY_MODE_INVALID;
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
prev parent reply other threads:[~2019-07-23 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 10:51 [PATCH] phy: marvell: phy-mvebu-a3700-comphy: Add of_node_put() before return Nishka Dasgupta
2019-07-23 14:08 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723160818.2bf7eb80@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).