From: Bjorn Helgaas <helgaas@kernel.org>
To: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v3] PCI: Remove functions not called in include/linux/pci.h
Date: Tue, 23 Jul 2019 18:34:25 -0500 [thread overview]
Message-ID: <20190723233424.GC47047@google.com> (raw)
In-Reply-To: <20190715203416.37547-1-skunberg.kelsey@gmail.com>
On Mon, Jul 15, 2019 at 02:34:16PM -0600, Kelsey Skunberg wrote:
> Remove the following uncalled functions from include/linux/pci.h:
>
> pci_block_cfg_access()
> pci_block_cfg_access_in_atomic()
> pci_unblock_cfg_access()
>
> Functions were added in commit fb51ccbf217c ("PCI: Rework config space
> blocking services"), though no callers were added. Code continues to be
> unused and should be removed.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Applied with Lukas' reviewed-by (thank you!) to pci/hide for v5.4,
thanks!
> ---
>
> Changes since v1:
> - Fixed Signed-off-by line to show full name
>
> Changes since v2:
> - Change commit message to reference prior commit properly with the
> following format:
> commit <12-character sha prefix> ("<commit message>")
>
> include/linux/pci.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index cf380544c700..3c9ba6133bea 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1656,11 +1656,6 @@ static inline void pci_release_regions(struct pci_dev *dev) { }
>
> static inline unsigned long pci_address_to_pio(phys_addr_t addr) { return -1; }
>
> -static inline void pci_block_cfg_access(struct pci_dev *dev) { }
> -static inline int pci_block_cfg_access_in_atomic(struct pci_dev *dev)
> -{ return 0; }
> -static inline void pci_unblock_cfg_access(struct pci_dev *dev) { }
> -
> static inline struct pci_bus *pci_find_next_bus(const struct pci_bus *from)
> { return NULL; }
> static inline struct pci_dev *pci_get_slot(struct pci_bus *bus,
> --
> 2.20.1
>
> _______________________________________________
> Linux-kernel-mentees mailing list
> Linux-kernel-mentees@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
prev parent reply other threads:[~2019-07-23 23:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 17:56 [PATCH] PCI: Remove functions not called in include/linux/pci.h Kelsey
2019-07-15 18:13 ` [PATCH v2] " Kelsey Skunberg
2019-07-15 19:42 ` [Linux-kernel-mentees] " Lukas Bulwahn
2019-07-15 20:19 ` Kelsey Skunberg
2019-07-15 23:37 ` Bjorn Helgaas
2019-07-16 3:57 ` Kelsey Skunberg
2019-07-15 20:34 ` [PATCH v3] " Kelsey Skunberg
2019-07-16 4:58 ` [Linux-kernel-mentees] " Lukas Bulwahn
2019-07-23 23:34 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723233424.GC47047@google.com \
--to=helgaas@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=skunberg.kelsey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).