From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E487BC7618B for ; Wed, 24 Jul 2019 11:32:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD539229ED for ; Wed, 24 Jul 2019 11:32:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="M8c9YZKY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727512AbfGXLc5 (ORCPT ); Wed, 24 Jul 2019 07:32:57 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:37397 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727083AbfGXLcz (ORCPT ); Wed, 24 Jul 2019 07:32:55 -0400 Received: by mail-qt1-f194.google.com with SMTP id y26so45080684qto.4 for ; Wed, 24 Jul 2019 04:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eynjgUU3LO9/cX6Oi8VqmlxPxhsFPzKIycVhDFmwkho=; b=M8c9YZKYL5TIbtUIVVLH5qwpFoFyhUZ9ccOGIkFj4eVt+NECKrDV/Kkcji4bpstToy UPmw29H922tPtKY46av4Yuuua0qB4GXCEo25rkRUIVpsfuQvrhm2rN1+5swV89eUwije +1YrWpVEa1b++e3eZrgwLuk/hMOtTzvD0244mqysh/TPjzY0TENWGBUBjgUJ1huQ6MVY kpoXR7KhxUEnbbE1V+EPLuWhO6rD2kl68BV8aFYBIIexS7btc+0awTM3iRXyguhyQkAv kbFN1EJA3ccjPEZdYq7fif+3mvIXObB0JQLqcAbRNHT6my6ARwZgCFU4EwDOucFZ2gXI rnLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eynjgUU3LO9/cX6Oi8VqmlxPxhsFPzKIycVhDFmwkho=; b=OcyoKBvSSA+fZaWOwziGhg2ilAVjvAmvDS4XMJlYeH8IxH7Y5PGnabDMKAzBvPMkMD NAU9Do+3v8/xzYg+Nz6OLCWXV+zMNo0RfyUG7OyKGQ+esk5bYbBtTMQFRe2v2lVolTMj wsaYMdTZqpL05/kjrDljHQzQslD2le6N5BAfq+hk5b9o01v/fLjSTCuVdHsIQpk3fRVq j11OpPLlUnJfAu2wctn6iRBGwwSCJsM4REdlqJQCDcY5YXA0xKQTRfG0BzWk8Ibxbkx5 BqbvHg9iFVc0oEYm45J4vA5GXIUqrb3BG5gaUAJOpdIAsXe3HeSE8o3qJuqR2nD5Ll8W Y6PA== X-Gm-Message-State: APjAAAV+K9bDrfLDF3sIhMJVb61v6PItCr+BvAj/UOPa0jApnlgIkDi1 GWfxLBpavydRMXSdRqWtYqbdvg== X-Google-Smtp-Source: APXvYqxDoEA7McnePKPXUTQRMBXSoB6Dq/gMsyEXzcL8Xc9EMyCc9NVWXUrhefddcSkU76K9Igsmlg== X-Received: by 2002:a0c:b50c:: with SMTP id d12mr58124931qve.70.1563967974002; Wed, 24 Jul 2019 04:32:54 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id y42sm30058475qtc.66.2019.07.24.04.32.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jul 2019 04:32:53 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hqFVs-0007jC-7Q; Wed, 24 Jul 2019 08:32:52 -0300 Date: Wed, 24 Jul 2019 08:32:52 -0300 From: Jason Gunthorpe To: YueHaibing Cc: oulijun@huawei.com, xavier.huwei@huawei.com, dledford@redhat.com, leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH] RDMA/hns: Fix build error Message-ID: <20190724113252.GA28493@ziepe.ca> References: <20190723024908.11876-1-yuehaibing@huawei.com> <20190724065443.53068-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190724065443.53068-1-yuehaibing@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 24, 2019 at 02:54:43PM +0800, YueHaibing wrote: > If INFINIBAND_HNS_HIP08 is selected and HNS3 is m, > but INFINIBAND_HNS is y, building fails: > > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_exit': > hns_roce_hw_v2.c:(.exit.text+0xd): undefined reference to `hnae3_unregister_client' > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_init': > hns_roce_hw_v2.c:(.init.text+0xd): undefined reference to `hnae3_register_client' > > Also if INFINIBAND_HNS_HIP06 is selected and HNS_DSAF > is m, but INFINIBAND_HNS is y, building fails: > > drivers/infiniband/hw/hns/hns_roce_hw_v1.o: In function `hns_roce_v1_reset': > hns_roce_hw_v1.c:(.text+0x39fa): undefined reference to `hns_dsaf_roce_reset' > hns_roce_hw_v1.c:(.text+0x3a25): undefined reference to `hns_dsaf_roce_reset' > > Reported-by: Hulk Robot > Fixes: dd74282df573 ("RDMA/hns: Initialize the PCI device for hip08 RoCE") > Fixes: 08805fdbeb2d ("RDMA/hns: Split hw v1 driver from hns roce driver") > Signed-off-by: YueHaibing > drivers/infiniband/hw/hns/Kconfig | 6 +++--- > drivers/infiniband/hw/hns/Makefile | 8 ++------ > 2 files changed, 5 insertions(+), 9 deletions(-) did you test this approach with CONFIG_MODULES=n? Jason