From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B651C7618B for ; Wed, 24 Jul 2019 11:44:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DAFD22387 for ; Wed, 24 Jul 2019 11:44:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="KXCF/Bzh"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="XXAQBvA7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbfGXLop (ORCPT ); Wed, 24 Jul 2019 07:44:45 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47744 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727532AbfGXLoo (ORCPT ); Wed, 24 Jul 2019 07:44:44 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3839860867; Wed, 24 Jul 2019 11:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563968683; bh=WI7OaJbzQRsGararuSzJi7gI7JPxnUOnrorpDxfrFkE=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=KXCF/Bzhfi4lPF5yE4ZqI8iiO77/W3AIX+NujPjM2sX53hHq2z0iDttyyJ79cuA27 t5r7TBhSN1Z+ciySeB5KiI2YaZER8e24N/O1m4CwRL/umPz0v4na8N4x6OZxY7oShT P7HK3pVgVAyk0Ti6esCyNUiy/XdKpEnF4NQZ/NyM= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 55CA3619C9; Wed, 24 Jul 2019 11:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563968682; bh=WI7OaJbzQRsGararuSzJi7gI7JPxnUOnrorpDxfrFkE=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=XXAQBvA7djWIlFOdpwpGwntAYQCH9VxiZVn0L+L3A02K1o2DAPS8t51q8KMLiYrWg bcSSxBow0pa/rnqXLBiPdugF/kiBxKuttCAsa73Et45+WpMPCGGWm1wNIW1msoCLEn 1xphQvUE4agBk28XEzTMPTImNy6rjlbgBUeCAOsU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 55CA3619C9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] libertas: remove redundant assignment to variable ret From: Kalle Valo In-Reply-To: <20190705081734.15292-1-colin.king@canonical.com> References: <20190705081734.15292-1-colin.king@canonical.com> To: Colin King Cc: "David S . Miller" , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190724114443.3839860867@smtp.codeaurora.org> Date: Wed, 24 Jul 2019 11:44:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with a value that is never > read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 4c8a46851019 libertas: remove redundant assignment to variable ret -- https://patchwork.kernel.org/patch/11032181/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches