From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41995C76186 for ; Wed, 24 Jul 2019 20:02:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15B8820665 for ; Wed, 24 Jul 2019 20:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563998521; bh=bL8YoDvzPS1ySbiik56MM80M7obDeHxRCnzY3CCkZnE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NujbQ6F9Y2IneFHR6blWot0REKlCab8OgWhnp6d/HXX78VPQ89rxH2nOTDyk951CP 8p55USVxXEmxAiN4n6dpiMOJyHFLp4KouFyHKFX30SSNvv03Aav8Umcb9LhE/cvLyM qgiZi4JUY1Z6NCOBff1Y1p9NmfMgp6UZ3PdrI9cQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392369AbfGXUCA (ORCPT ); Wed, 24 Jul 2019 16:02:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:51254 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392243AbfGXUB6 (ORCPT ); Wed, 24 Jul 2019 16:01:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 199882147A; Wed, 24 Jul 2019 20:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563998517; bh=bL8YoDvzPS1ySbiik56MM80M7obDeHxRCnzY3CCkZnE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yiKrGUi9QvfwBpGATtimXdPQ0gK1Q09rcUJqh8vqhjJhXVXhojeqfpOqWQ9NM5eP/ EKaEJj1Pb6QXLbrj8kl1IhPwexkmusW30u6LMkj0NMOEzYKPHamc90isrqm+rAKdLK Baw1pIQTD1cN+Q9WdGnOxE0Z/aU2WCBMXwizDdm8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jungo Lin , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 021/271] media: media_device_enum_links32: clean a reserved field Date: Wed, 24 Jul 2019 21:18:10 +0200 Message-Id: <20190724191657.052337810@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191655.268628197@linuxfoundation.org> References: <20190724191655.268628197@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit f49308878d7202e07d8761238e01bd0e5fce2750 ] In v4l2-compliance utility, test MEDIA_IOC_ENUM_ENTITIES will check whether reserved field of media_links_enum filled with zero. However, for 32 bit program, the reserved field is missing copy from kernel space to user space in media_device_enum_links32 function. This patch adds the cleaning a reserved field logic in media_device_enum_links32 function. Signed-off-by: Jungo Lin Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/media-device.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index 3bae24b15eaa..ba344e6f0139 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -487,6 +487,7 @@ static long media_device_enum_links32(struct media_device *mdev, { struct media_links_enum links; compat_uptr_t pads_ptr, links_ptr; + int ret; memset(&links, 0, sizeof(links)); @@ -498,7 +499,13 @@ static long media_device_enum_links32(struct media_device *mdev, links.pads = compat_ptr(pads_ptr); links.links = compat_ptr(links_ptr); - return media_device_enum_links(mdev, &links); + ret = media_device_enum_links(mdev, &links); + if (ret) + return ret; + + memset(ulinks->reserved, 0, sizeof(ulinks->reserved)); + + return 0; } #define MEDIA_IOC_ENUM_LINKS32 _IOWR('|', 0x02, struct media_links_enum32) -- 2.20.1