From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E891C76191 for ; Wed, 24 Jul 2019 19:23:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6ACA8218F0 for ; Wed, 24 Jul 2019 19:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996181; bh=MPPw1uoU0k3SyAgvQYcNjMXtfzBpCdPnQhRHIqRxuuM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=q4JcvHKH1aqrzaSTi4l30avzIR68KWRqmaULrdDN6LYnhEH7emLZbHVD8yt4JK9dD YRXlcGJyYmTVm4x9ezv6F3CQtvFFCXyyGmKN7bLB7sKwRYlbMlozYIyydYdVPsTP35 /O8cQOtKmsrtICV79pLAYERAIyWV2leivZYkTymE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728087AbfGXTXA (ORCPT ); Wed, 24 Jul 2019 15:23:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:38446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726470AbfGXTXA (ORCPT ); Wed, 24 Jul 2019 15:23:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 587F0218EA; Wed, 24 Jul 2019 19:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996179; bh=MPPw1uoU0k3SyAgvQYcNjMXtfzBpCdPnQhRHIqRxuuM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gr+X4O+/BB6P1jeiJqTOeuonj/gEs1R9HQgItq5YsEkiTq5FHy5aE52k/ZFa421As NBMJ5wpui2Py8xxgGOuzZEDrru2dyhwJdmQ78Pm/7fNlyHcZH0iLyT5Q7bymTidCZV 7XgrlhpxbciIgypxdUpU46JRaNmbbx1KR1FTMlRk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yingying Tang , Kalle Valo , Sasha Levin Subject: [PATCH 5.2 001/413] ath10k: Check tx_stats before use it Date: Wed, 24 Jul 2019 21:14:52 +0200 Message-Id: <20190724191735.240631663@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191735.096702571@linuxfoundation.org> References: <20190724191735.096702571@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 9e7251fa38978b85108c44743e1436d48e8d0d76 ] tx_stats will be freed and set to NULL before debugfs_sta node is removed in station disconnetion process. So if read the debugfs_sta node there may be NULL pointer error. Add check for tx_stats before use it to resove this issue. Signed-off-by: Yingying Tang Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath10k/debugfs_sta.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/debugfs_sta.c b/drivers/net/wireless/ath/ath10k/debugfs_sta.c index c704ae371c4d..42931a669b02 100644 --- a/drivers/net/wireless/ath/ath10k/debugfs_sta.c +++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c @@ -663,6 +663,13 @@ static ssize_t ath10k_dbg_sta_dump_tx_stats(struct file *file, mutex_lock(&ar->conf_mutex); + if (!arsta->tx_stats) { + ath10k_warn(ar, "failed to get tx stats"); + mutex_unlock(&ar->conf_mutex); + kfree(buf); + return 0; + } + spin_lock_bh(&ar->data_lock); for (k = 0; k < ATH10K_STATS_TYPE_MAX; k++) { for (j = 0; j < ATH10K_COUNTER_TYPE_MAX; j++) { -- 2.20.1