From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA52DC76186 for ; Wed, 24 Jul 2019 19:29:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC3F7218EA for ; Wed, 24 Jul 2019 19:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996559; bh=SpUzqcby77o16NTeR8QQjkQPeC1IXxgQdO+ttTluORo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tNtBoSZ9VPWns92KMIiEAJnKN73RQrgVifmlWXS+w9roJxR4+DC9HlKG9rPzlrCVC S8+mJqfw/Wlt22EI5ryGWjsI6+mqDDEP6boh5kZ1H/t+MU8ZHqp+sxIkghKzw3cEww CTuHKy/9JP74Tk4gwM2NuYv0yXb+U5irRGqvmx9w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728933AbfGXT3S (ORCPT ); Wed, 24 Jul 2019 15:29:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:48306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388337AbfGXT3O (ORCPT ); Wed, 24 Jul 2019 15:29:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5272E22ADA; Wed, 24 Jul 2019 19:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996553; bh=SpUzqcby77o16NTeR8QQjkQPeC1IXxgQdO+ttTluORo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eQ2BfTgfg+EMBBQH0zfLjg3WBQxCuBdh9NSEmUJLLPIq7yzBI+EQXBZAPzeQEfmfN CctV8ON5apA/hAg74ay1m5hRMvKFnaOkE9Nm0k7LcTzEwIAiM72IMdpn0MKLODMZ9X RIPTLFm6f1uUZ1sLtgL5bhrtfQ+59GTftcYUuNGI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Herbert Xu , Steffen Klassert , Sasha Levin Subject: [PATCH 5.2 138/413] ipsec: select crypto ciphers for xfrm_algo Date: Wed, 24 Jul 2019 21:17:09 +0200 Message-Id: <20190724191744.906896939@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191735.096702571@linuxfoundation.org> References: <20190724191735.096702571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 597179b0ba550bd83fab1a9d57c42a9343c58514 ] kernelci.org reports failed builds on arc because of what looks like an old missed 'select' statement: net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash' I don't see this in randconfig builds on other architectures, but it's fairly clear we want to select the hash code for it, like we do for all its other users. As Herbert points out, CRYPTO_BLKCIPHER is also required even though it has not popped up in build tests. Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms") Signed-off-by: Arnd Bergmann Acked-by: Herbert Xu Signed-off-by: Steffen Klassert Signed-off-by: Sasha Levin --- net/xfrm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index c967fc3c38c8..51bb6018f3bf 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -15,6 +15,8 @@ config XFRM_ALGO tristate select XFRM select CRYPTO + select CRYPTO_HASH + select CRYPTO_BLKCIPHER if INET config XFRM_USER -- 2.20.1