From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6EAC7618B for ; Thu, 25 Jul 2019 12:26:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B209122BF5 for ; Thu, 25 Jul 2019 12:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729867AbfGYM01 (ORCPT ); Thu, 25 Jul 2019 08:26:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:51428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfGYM01 (ORCPT ); Thu, 25 Jul 2019 08:26:27 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 248B6206BA; Thu, 25 Jul 2019 12:26:23 +0000 (UTC) Date: Thu, 25 Jul 2019 08:26:21 -0400 From: Steven Rostedt To: Lu Baolu Cc: David Woodhouse , Joerg Roedel , Bjorn Helgaas , Christoph Hellwig , ashok.raj@intel.com, jacob.jun.pan@intel.com, alan.cox@intel.com, kevin.tian@intel.com, mika.westerberg@linux.intel.com, Ingo Molnar , Greg Kroah-Hartman , pengfei.xu@intel.com, Konrad Rzeszutek Wilk , Marek Szyprowski , Robin Murphy , Jonathan Corbet , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jacob Pan Subject: Re: [PATCH v5 09/10] iommu/vt-d: Add trace events for device dma map/unmap Message-ID: <20190725082621.2878936a@gandalf.local.home> In-Reply-To: <20190725031717.32317-10-baolu.lu@linux.intel.com> References: <20190725031717.32317-1-baolu.lu@linux.intel.com> <20190725031717.32317-10-baolu.lu@linux.intel.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jul 2019 11:17:16 +0800 Lu Baolu wrote: > This adds trace support for the Intel IOMMU driver. It > also declares some events which could be used to trace > the events when an IOVA is being mapped or unmapped in > a domain. > > Cc: Ashok Raj > Cc: Jacob Pan > Cc: Kevin Tian > Signed-off-by: Mika Westerberg > Signed-off-by: Lu Baolu > --- > drivers/iommu/Makefile | 1 + > drivers/iommu/intel-trace.c | 14 +++++ > include/trace/events/intel_iommu.h | 95 ++++++++++++++++++++++++++++++ > 3 files changed, 110 insertions(+) > create mode 100644 drivers/iommu/intel-trace.c > create mode 100644 include/trace/events/intel_iommu.h This patch looks fine, but I don't see the use cases for anything but trace_bounce_map_single() and trace_bounce_unmap_single() used. Other than that. Reviewed-by: Steven Rostedt (VMware) -- Steve > > diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile > index f13f36ae1af6..bfe27b2755bd 100644 > --- a/drivers/iommu/Makefile > +++ b/drivers/iommu/Makefile > @@ -17,6 +17,7 @@ obj-$(CONFIG_ARM_SMMU) += arm-smmu.o > obj-$(CONFIG_ARM_SMMU_V3) += arm-smmu-v3.o > obj-$(CONFIG_DMAR_TABLE) += dmar.o > obj-$(CONFIG_INTEL_IOMMU) += intel-iommu.o intel-pasid.o > +obj-$(CONFIG_INTEL_IOMMU) += intel-trace.o > obj-$(CONFIG_INTEL_IOMMU_DEBUGFS) += intel-iommu-debugfs.o > obj-$(CONFIG_INTEL_IOMMU_SVM) += intel-svm.o > obj-$(CONFIG_IPMMU_VMSA) += ipmmu-vmsa.o > diff --git a/drivers/iommu/intel-trace.c b/drivers/iommu/intel-trace.c > new file mode 100644 > index 000000000000..bfb6a6e37a88 > --- /dev/null > +++ b/drivers/iommu/intel-trace.c > @@ -0,0 +1,14 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Intel IOMMU trace support > + * > + * Copyright (C) 2019 Intel Corporation > + * > + * Author: Lu Baolu > + */ > + > +#include > +#include > + > +#define CREATE_TRACE_POINTS > +#include > diff --git a/include/trace/events/intel_iommu.h b/include/trace/events/intel_iommu.h > new file mode 100644 > index 000000000000..3fdeaad93b2e > --- /dev/null > +++ b/include/trace/events/intel_iommu.h > @@ -0,0 +1,95 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Intel IOMMU trace support > + * > + * Copyright (C) 2019 Intel Corporation > + * > + * Author: Lu Baolu > + */ > +#ifdef CONFIG_INTEL_IOMMU > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM intel_iommu > + > +#if !defined(_TRACE_INTEL_IOMMU_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_INTEL_IOMMU_H > + > +#include > +#include > + > +DECLARE_EVENT_CLASS(dma_map, > + TP_PROTO(struct device *dev, dma_addr_t dev_addr, phys_addr_t phys_addr, > + size_t size), > + > + TP_ARGS(dev, dev_addr, phys_addr, size), > + > + TP_STRUCT__entry( > + __string(dev_name, dev_name(dev)) > + __field(dma_addr_t, dev_addr) > + __field(phys_addr_t, phys_addr) > + __field(size_t, size) > + ), > + > + TP_fast_assign( > + __assign_str(dev_name, dev_name(dev)); > + __entry->dev_addr = dev_addr; > + __entry->phys_addr = phys_addr; > + __entry->size = size; > + ), > + > + TP_printk("dev=%s dev_addr=0x%llx phys_addr=0x%llx size=%zu", > + __get_str(dev_name), > + (unsigned long long)__entry->dev_addr, > + (unsigned long long)__entry->phys_addr, > + __entry->size) > +); > + > +DEFINE_EVENT(dma_map, bounce_map_single, > + TP_PROTO(struct device *dev, dma_addr_t dev_addr, phys_addr_t phys_addr, > + size_t size), > + TP_ARGS(dev, dev_addr, phys_addr, size) > +); > + > +DEFINE_EVENT(dma_map, bounce_map_sg, > + TP_PROTO(struct device *dev, dma_addr_t dev_addr, phys_addr_t phys_addr, > + size_t size), > + TP_ARGS(dev, dev_addr, phys_addr, size) > +); > + > +DECLARE_EVENT_CLASS(dma_unmap, > + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size), > + > + TP_ARGS(dev, dev_addr, size), > + > + TP_STRUCT__entry( > + __string(dev_name, dev_name(dev)) > + __field(dma_addr_t, dev_addr) > + __field(size_t, size) > + ), > + > + TP_fast_assign( > + __assign_str(dev_name, dev_name(dev)); > + __entry->dev_addr = dev_addr; > + __entry->size = size; > + ), > + > + TP_printk("dev=%s dev_addr=0x%llx size=%zu", > + __get_str(dev_name), > + (unsigned long long)__entry->dev_addr, > + __entry->size) > +); > + > +DEFINE_EVENT(dma_unmap, bounce_unmap_single, > + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size), > + TP_ARGS(dev, dev_addr, size) > +); > + > +DEFINE_EVENT(dma_unmap, bounce_unmap_sg, > + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size), > + TP_ARGS(dev, dev_addr, size) > +); > + > +#endif /* _TRACE_INTEL_IOMMU_H */ > + > +/* This part must be outside protection */ > +#include > +#endif /* CONFIG_INTEL_IOMMU */