From: Christoph Hellwig <hch@infradead.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Laura Abbott <labbott@redhat.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Liam Mark <lmark@codeaurora.org>,
Pratik Patel <pratikp@codeaurora.org>,
Brian Starkey <Brian.Starkey@arm.com>,
Vincent Donnefort <Vincent.Donnefort@arm.com>,
Sudipto Paul <Sudipto.Paul@arm.com>,
"Andrew F . Davis" <afd@ti.com>,
Christoph Hellwig <hch@infradead.org>,
Chenbo Feng <fengc@google.com>,
Alistair Strachan <astrachan@google.com>,
Hridya Valsaraju <hridya@google.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v7 2/5] dma-buf: heaps: Add heap helpers
Date: Thu, 25 Jul 2019 05:55:54 -0700 [thread overview]
Message-ID: <20190725125554.GF20286@infradead.org> (raw)
In-Reply-To: <20190724003656.59780-3-john.stultz@linaro.org>
> +struct dma_buf *heap_helper_export_dmabuf(
> + struct heap_helper_buffer *helper_buffer,
> + int fd_flags)
Indentation seems odd here as it doesn't follow any of the usual schools
for multi-level prototypes. But maybe shortening some identifier would
help avoiding that problem altogether :)
> +static void *dma_heap_map_kernel(struct heap_helper_buffer *buffer)
> +{
> + void *vaddr;
> +
> + vaddr = vmap(buffer->pages, buffer->pagecount, VM_MAP, PAGE_KERNEL);
> + if (!vaddr)
> + return ERR_PTR(-ENOMEM);
> +
> + return vaddr;
> +}
Note that a lot of systems don't have highmem at all or don't support
CMA in highmem. So for contigous allocations that aren't highmem we
could skip the vmap here altogether and just use the direct mapping.
next prev parent reply other threads:[~2019-07-25 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 0:36 [PATCH v7 0/5] DMA-BUF Heaps (destaging ION) John Stultz
2019-07-24 0:36 ` [PATCH v7 1/5] dma-buf: Add dma-buf heaps framework John Stultz
2019-07-24 0:36 ` [PATCH v7 2/5] dma-buf: heaps: Add heap helpers John Stultz
2019-07-25 12:55 ` Christoph Hellwig [this message]
2019-07-24 0:36 ` [PATCH v7 3/5] dma-buf: heaps: Add system heap to dmabuf heaps John Stultz
2019-07-25 13:02 ` Christoph Hellwig
2019-07-25 18:55 ` Andrew F. Davis
2019-07-25 19:02 ` John Stultz
2019-07-24 0:36 ` [PATCH v7 4/5] dma-buf: heaps: Add CMA " John Stultz
2019-07-24 0:36 ` [PATCH v7 5/5] kselftests: Add dma-heap test John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725125554.GF20286@infradead.org \
--to=hch@infradead.org \
--cc=Brian.Starkey@arm.com \
--cc=Sudipto.Paul@arm.com \
--cc=Vincent.Donnefort@arm.com \
--cc=afd@ti.com \
--cc=astrachan@google.com \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengc@google.com \
--cc=hridya@google.com \
--cc=john.stultz@linaro.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=pratikp@codeaurora.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).