From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C239DC76194 for ; Thu, 25 Jul 2019 20:01:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 925322190F for ; Thu, 25 Jul 2019 20:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564084891; bh=7EZzVbIDDiKaWsszB4jZkzLg73JVW3NW7ARC/KFNUjo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zf12Lt0bPWtBkCA9A3RcjIiyRmq4RpLfL2nsBOVbdSgJvmyMxZWp+4RJJbJwOK7cW eJniEXziqHwcQXzHFJGPacL8q5wkXyscie8BSnmOVM//2JkgFTki7CH40lfBLKkKuu g8ehnxzNgikfFltilP+kZlH9zemrHvrjLdWHtSwM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726618AbfGYUBa (ORCPT ); Thu, 25 Jul 2019 16:01:30 -0400 Received: from mga12.intel.com ([192.55.52.136]:18882 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726166AbfGYUBa (ORCPT ); Thu, 25 Jul 2019 16:01:30 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 13:01:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,307,1559545200"; d="scan'208";a="175361989" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga006.jf.intel.com with ESMTP; 25 Jul 2019 13:01:28 -0700 Date: Thu, 25 Jul 2019 13:58:35 -0600 From: Keith Busch To: Logan Gunthorpe Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Jens Axboe , Chaitanya Kulkarni , Max Gurtovoy , Stephen Bates Subject: Re: [PATCH v6 04/16] nvme-core: introduce nvme_get_by_path() Message-ID: <20190725195835.GA7317@localhost.localdomain> References: <20190725172335.6825-1-logang@deltatee.com> <20190725172335.6825-5-logang@deltatee.com> <20190725175023.GA30641@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2019 at 11:54:18AM -0600, Logan Gunthorpe wrote: > > > On 2019-07-25 11:50 a.m., Matthew Wilcox wrote: > > On Thu, Jul 25, 2019 at 11:23:23AM -0600, Logan Gunthorpe wrote: > >> nvme_get_by_path() is analagous to blkdev_get_by_path() except it > >> gets a struct nvme_ctrl from the path to its char dev (/dev/nvme0). > >> > >> The purpose of this function is to support NVMe-OF target passthru. > > > > I can't find anywhere that you use this in this patchset. > > > > Oh sorry, the commit message is out of date the function was actually > called nvme_ctrl_get_by_path() and it's used in Patch 10. Instead of by path, could we have configfs take something else, like the unique controller instance or serial number? I know that's different than how we handle blocks and files, but that way nvme core can lookup the cooresponding controller without adding new cdev dependencies.