From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FAKE_REPLY_C, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79523C76190 for ; Fri, 26 Jul 2019 12:36:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59F7422ADA for ; Fri, 26 Jul 2019 12:36:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727412AbfGZMgC (ORCPT ); Fri, 26 Jul 2019 08:36:02 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:46542 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbfGZMgB (ORCPT ); Fri, 26 Jul 2019 08:36:01 -0400 Received: from gondolin.me.apana.org.au ([192.168.0.6] helo=gondolin.hengli.com.au) by fornost.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hqzRy-00042T-46; Fri, 26 Jul 2019 22:35:54 +1000 Received: from herbert by gondolin.hengli.com.au with local (Exim 4.80) (envelope-from ) id 1hqzRx-0002EN-Fm; Fri, 26 Jul 2019 22:35:53 +1000 Date: Fri, 26 Jul 2019 22:35:53 +1000 From: Herbert Xu To: Iuliana Prodan Cc: davem@davemloft.net, gilad@benyossef.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH 1/2] crypto: ccree - check assoclen for rfc4543 Message-ID: <20190726123553.GA8568@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1563520164-1153-1-git-send-email-iuliana.prodan@nxp.com> Organization: Core X-Newsgroups: apana.lists.os.linux.cryptoapi,apana.lists.os.linux.kernel User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Iuliana Prodan wrote: > Check assoclen to solve the extra tests that expect -EINVAL to be > returned when the associated data size is not valid. > > Validated assoclen for RFC4543 which expects an assoclen > of 16 or 20, the same as RFC4106. > Based on seqiv, IPsec ESP and RFC4543/RFC4106 the assoclen is sizeof > IP Header (spi, seq_no, extended seq_no) and IV len. This can be 16 or > 20 bytes. > > Signed-off-by: Iuliana Prodan > --- > drivers/crypto/ccree/cc_aead.c | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt