From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 083BFC7618B for ; Fri, 26 Jul 2019 14:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C940822C7E for ; Fri, 26 Jul 2019 14:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564150289; bh=hF4P0NSUt1UMtwss/k6Y5M453YUX4ips7z7TFzgxoWM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zhERVw1WYCwxkwJZnjhuQx1IcuhIo+AlD/9u/DcktusWBjTyc8OkGa9v37XRG6Cwt J8BweyRC0zUVzIvlIMOgBLkXcP2O0VAqVCx6dYuWD/iHGzyEw1dlpMNzP+rTWC0CJt whuvaHn6XMVRPgInLie651ChQ7lMf2siDuX26OSw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728377AbfGZOL2 (ORCPT ); Fri, 26 Jul 2019 10:11:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:45918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727397AbfGZOL2 (ORCPT ); Fri, 26 Jul 2019 10:11:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93652218D3; Fri, 26 Jul 2019 14:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564150287; bh=hF4P0NSUt1UMtwss/k6Y5M453YUX4ips7z7TFzgxoWM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DrFGCFGe3nGdvNVEPC5e3DkB9dB6UtwpR8gwlmRgYlQ3ZWfmuMCk9mxghyq8A3IuD I+lFzw7xoDMMoRuMIlLkEoJKHdOqXl9EWqnvXCI7PBH46iBa1g8M8eKMio/QnVBXK+ fz2UijrKpVM0sQUlhZmxdnZUOSIGSbQjVFO2SK/Q= Date: Fri, 26 Jul 2019 16:11:24 +0200 From: Greg KH To: Pierre-Louis Bossart Cc: Cezary Rojewski , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Sanyog Kale Subject: Re: [alsa-devel] [RFC PATCH 04/40] soundwire: intel: add debugfs register dump Message-ID: <20190726141124.GA4253@kroah.com> References: <20190725234032.21152-1-pierre-louis.bossart@linux.intel.com> <20190725234032.21152-5-pierre-louis.bossart@linux.intel.com> <9d5bc940-eadd-4f82-0bac-6a731369436d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 26, 2019 at 09:00:28AM -0500, Pierre-Louis Bossart wrote: > > > On 7/26/19 4:35 AM, Cezary Rojewski wrote: > > On 2019-07-26 01:39, Pierre-Louis Bossart wrote: > > > +static void intel_debugfs_init(struct sdw_intel *sdw) > > > +{ > > > +    struct dentry *root = sdw->cdns.bus.debugfs; > > > + > > > +    if (!root) > > > +        return; > > > + > > > +    sdw->fs = debugfs_create_dir("intel-sdw", root); > > > +    if (IS_ERR_OR_NULL(sdw->fs)) { > > > +        dev_err(sdw->cdns.dev, "debugfs root creation failed\n"); > > > +        sdw->fs = NULL; > > > +        return; > > > +    } > > > + > > > +    debugfs_create_file("intel-registers", 0400, sdw->fs, sdw, > > > +                &intel_reg_fops); > > > + > > > +    sdw_cdns_debugfs_init(&sdw->cdns, sdw->fs); > > > +} > > > > I believe there should be dummy equivalent of _init and _exit if debugfs > > is not enabled (if these are defined already and I've missed it, please > > ignore). > > I think the direction is just to keep going if there is an error or debufs > is not enabled. You should not care either way :)