From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1706CC7618B for ; Fri, 26 Jul 2019 15:26:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBA59218D4 for ; Fri, 26 Jul 2019 15:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564154809; bh=eBinwqcJdtssqV8okGdFjjiIvIlF+S1X3v/D2boZEqc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rNJeKr8lTO7Y2b7ddXZ6uuP0NGqo04PDyfrUfIzE0dOOp0QKNMKPN4xuNsBEyOh7D +06k3/aDZMjZeFOKQUUa/ByjktwSM0liouvY8+USbHFrxyIMAwDiDP7rFxBeOvt9+u gIYutlj26fZk4JcJFry8CpqqpPHm0vW/fh7j8rHI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388083AbfGZP0s (ORCPT ); Fri, 26 Jul 2019 11:26:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:40830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387976AbfGZP0q (ORCPT ); Fri, 26 Jul 2019 11:26:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F9DE218D4; Fri, 26 Jul 2019 15:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564154805; bh=eBinwqcJdtssqV8okGdFjjiIvIlF+S1X3v/D2boZEqc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HBBCPDNPIeP2nXOeZ46NzJYp0TMhVOdGWbQbHiTbOY1y/PREPfvQhK3j+xtEXpVc5 cie+Tck6NcLxRbi4UjSIrhvU3SUG62fJueFwQ9cCJMiUV34JUTEBCGpUOpyGMj1jEl oLNO9lwYusoFi2fFxP5IrIp1rObL+0I+c9QyLzaI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nikolay Aleksandrov , "David S. Miller" Subject: [PATCH 5.2 31/66] net: bridge: stp: dont cache eth dest pointer before skb pull Date: Fri, 26 Jul 2019 17:24:30 +0200 Message-Id: <20190726152305.217987566@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190726152301.936055394@linuxfoundation.org> References: <20190726152301.936055394@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nikolay Aleksandrov [ Upstream commit 2446a68ae6a8cee6d480e2f5b52f5007c7c41312 ] Don't cache eth dest pointer before calling pskb_may_pull. Fixes: cf0f02d04a83 ("[BRIDGE]: use llc for receiving STP packets") Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/bridge/br_stp_bpdu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/net/bridge/br_stp_bpdu.c +++ b/net/bridge/br_stp_bpdu.c @@ -143,7 +143,6 @@ void br_send_tcn_bpdu(struct net_bridge_ void br_stp_rcv(const struct stp_proto *proto, struct sk_buff *skb, struct net_device *dev) { - const unsigned char *dest = eth_hdr(skb)->h_dest; struct net_bridge_port *p; struct net_bridge *br; const unsigned char *buf; @@ -172,7 +171,7 @@ void br_stp_rcv(const struct stp_proto * if (p->state == BR_STATE_DISABLED) goto out; - if (!ether_addr_equal(dest, br->group_addr)) + if (!ether_addr_equal(eth_hdr(skb)->h_dest, br->group_addr)) goto out; if (p->flags & BR_BPDU_GUARD) {