From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F186AC7618B for ; Fri, 26 Jul 2019 16:03:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C858522BEF for ; Fri, 26 Jul 2019 16:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726982AbfGZQDD (ORCPT ); Fri, 26 Jul 2019 12:03:03 -0400 Received: from mga12.intel.com ([192.55.52.136]:26255 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726890AbfGZQDD (ORCPT ); Fri, 26 Jul 2019 12:03:03 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 09:03:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,311,1559545200"; d="scan'208";a="198413741" Received: from gliakhov-mobl2.ger.corp.intel.com (HELO ubuntu) ([10.249.35.244]) by fmsmga002.fm.intel.com with ESMTP; 26 Jul 2019 09:03:00 -0700 Date: Fri, 26 Jul 2019 18:02:59 +0200 From: Guennadi Liakhovetski To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale Subject: Re: [alsa-devel] [RFC PATCH 38/40] soundwire: cadence_master: make clock stop exit configurable on init Message-ID: <20190726160258.GN16003@ubuntu> References: <20190725234032.21152-1-pierre-louis.bossart@linux.intel.com> <20190725234032.21152-39-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190725234032.21152-39-pierre-louis.bossart@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2019 at 06:40:30PM -0500, Pierre-Louis Bossart wrote: > The use of clock stop is not a requirement, the IP can e.g. be > completely power gated and not detect any wakes while in s2idle/deep > sleep. > > Signed-off-by: Pierre-Louis Bossart > --- > drivers/soundwire/cadence_master.c | 15 ++++++++------- > drivers/soundwire/cadence_master.h | 2 +- > drivers/soundwire/intel.c | 2 +- > 3 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c > index 53278aa2436f..4ab6f70d7705 100644 > --- a/drivers/soundwire/cadence_master.c > +++ b/drivers/soundwire/cadence_master.c > @@ -1010,7 +1010,7 @@ static u32 cdns_set_default_frame_shape(int n_rows, int n_cols) > * sdw_cdns_init() - Cadence initialization > * @cdns: Cadence instance > */ > -int sdw_cdns_init(struct sdw_cdns *cdns) > +int sdw_cdns_init(struct sdw_cdns *cdns, bool clock_stop_exit) > { > struct sdw_bus *bus = &cdns->bus; > struct sdw_master_prop *prop = &bus->prop; > @@ -1018,12 +1018,13 @@ int sdw_cdns_init(struct sdw_cdns *cdns) > int divider; > int ret; > > - /* Exit clock stop */ > - ret = cdns_clear_bit(cdns, CDNS_MCP_CONTROL, > - CDNS_MCP_CONTROL_CLK_STOP_CLR); > - if (ret < 0) { > - dev_err(cdns->dev, "Couldn't exit from clock stop\n"); > - return ret; > + if (clock_stop_exit) { > + ret = cdns_clear_bit(cdns, CDNS_MCP_CONTROL, > + CDNS_MCP_CONTROL_CLK_STOP_CLR); > + if (ret < 0) { > + dev_err(cdns->dev, "Couldn't exit from clock stop\n"); > + return ret; > + } > } > > /* Set clock divider */ > diff --git a/drivers/soundwire/cadence_master.h b/drivers/soundwire/cadence_master.h > index 1a0ba36dd78f..091b771b570d 100644 > --- a/drivers/soundwire/cadence_master.h > +++ b/drivers/soundwire/cadence_master.h > @@ -158,7 +158,7 @@ extern struct sdw_master_ops sdw_cdns_master_ops; > irqreturn_t sdw_cdns_irq(int irq, void *dev_id); > irqreturn_t sdw_cdns_thread(int irq, void *dev_id); > > -int sdw_cdns_init(struct sdw_cdns *cdns); > +int sdw_cdns_init(struct sdw_cdns *cdns, bool clock_stop_exit); > int sdw_cdns_pdi_init(struct sdw_cdns *cdns, > struct sdw_cdns_stream_config config); > int sdw_cdns_exit_reset(struct sdw_cdns *cdns); > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index 1192d5775484..db7bf2912767 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -1043,7 +1043,7 @@ static int intel_init(struct sdw_intel *sdw) > intel_link_power_up(sdw); > intel_shim_init(sdw); > > - return sdw_cdns_init(&sdw->cdns); > + return sdw_cdns_init(&sdw->cdns, false); This is the only caller of this function so far, so, it looks like the second argument ATM is always "false." I assume you foresee other uses with "true" in the future, otherwise maybe just fix it to false in the function? Thanks Guennadi > } > > /* > -- > 2.20.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel