linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] coresight: acpi: Static funnel support
@ 2019-07-26 16:08 Suzuki K Poulose
  2019-07-30 17:40 ` Mathieu Poirier
  0 siblings, 1 reply; 2+ messages in thread
From: Suzuki K Poulose @ 2019-07-26 16:08 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: linux-kernel, mathieu.poirier, coresight, Suzuki K Poulose

The ACPI bindings for CoreSight has been updated to add the device
id for non-programmable CoreSight funnels (aka static funnels) as of
v1.1 [0]. Add the ACPI id for static funnels in the driver.

[0] https://static.docs.arm.com/den0067/a/DEN0067_CoreSight_ACPI_1.1.pdf

Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 drivers/hwtracing/coresight/coresight-funnel.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c
index fa97cb9ab4f9..0c99848a5d69 100644
--- a/drivers/hwtracing/coresight/coresight-funnel.c
+++ b/drivers/hwtracing/coresight/coresight-funnel.c
@@ -5,6 +5,7 @@
  * Description: CoreSight Funnel driver
  */
 
+#include <linux/acpi.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/types.h>
@@ -302,11 +303,19 @@ static const struct of_device_id static_funnel_match[] = {
 	{}
 };
 
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id static_funnel_ids[] = {
+	{"ARMHC9FE", 0},
+	{},
+};
+#endif
+
 static struct platform_driver static_funnel_driver = {
 	.probe          = static_funnel_probe,
 	.driver         = {
 		.name   = "coresight-static-funnel",
 		.of_match_table = static_funnel_match,
+		.acpi_match_table = ACPI_PTR(static_funnel_ids),
 		.pm	= &funnel_dev_pm_ops,
 		.suppress_bind_attrs = true,
 	},
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] coresight: acpi: Static funnel support
  2019-07-26 16:08 [PATCH] coresight: acpi: Static funnel support Suzuki K Poulose
@ 2019-07-30 17:40 ` Mathieu Poirier
  0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2019-07-30 17:40 UTC (permalink / raw)
  To: Suzuki K Poulose
  Cc: linux-arm-kernel, Linux Kernel Mailing List, Coresight ML

On Fri, 26 Jul 2019 at 10:08, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>
> The ACPI bindings for CoreSight has been updated to add the device
> id for non-programmable CoreSight funnels (aka static funnels) as of
> v1.1 [0]. Add the ACPI id for static funnels in the driver.
>
> [0] https://static.docs.arm.com/den0067/a/DEN0067_CoreSight_ACPI_1.1.pdf
>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
>  drivers/hwtracing/coresight/coresight-funnel.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c
> index fa97cb9ab4f9..0c99848a5d69 100644
> --- a/drivers/hwtracing/coresight/coresight-funnel.c
> +++ b/drivers/hwtracing/coresight/coresight-funnel.c
> @@ -5,6 +5,7 @@
>   * Description: CoreSight Funnel driver
>   */
>
> +#include <linux/acpi.h>
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/types.h>
> @@ -302,11 +303,19 @@ static const struct of_device_id static_funnel_match[] = {
>         {}
>  };
>
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id static_funnel_ids[] = {
> +       {"ARMHC9FE", 0},
> +       {},
> +};
> +#endif
> +
>  static struct platform_driver static_funnel_driver = {
>         .probe          = static_funnel_probe,
>         .driver         = {
>                 .name   = "coresight-static-funnel",
>                 .of_match_table = static_funnel_match,
> +               .acpi_match_table = ACPI_PTR(static_funnel_ids),
>                 .pm     = &funnel_dev_pm_ops,
>                 .suppress_bind_attrs = true,
>         },

I haved also applied this patch.

Mathieu

> --
> 2.21.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-30 17:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-26 16:08 [PATCH] coresight: acpi: Static funnel support Suzuki K Poulose
2019-07-30 17:40 ` Mathieu Poirier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).