From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B591C433FF for ; Sat, 27 Jul 2019 20:23:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6723D20657 for ; Sat, 27 Jul 2019 20:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388253AbfG0UXQ (ORCPT ); Sat, 27 Jul 2019 16:23:16 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39734 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387841AbfG0UXP (ORCPT ); Sat, 27 Jul 2019 16:23:15 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 20DB61533CD32; Sat, 27 Jul 2019 13:23:15 -0700 (PDT) Date: Sat, 27 Jul 2019 13:23:14 -0700 (PDT) Message-Id: <20190727.132314.1888016313569976606.davem@davemloft.net> To: mcroce@redhat.com Cc: antoine.tenart@bootlin.com, netdev@vger.kernel.org, maxime.chevallier@bootlin.com, mw@semihalf.com, stefanc@marvell.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] mvpp2: document HW checksum behaviour From: David Miller In-Reply-To: References: <20190725231546.23878-1-mcroce@redhat.com> <20190726125715.GB5031@kwain> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 27 Jul 2019 13:23:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matteo Croce Date: Fri, 26 Jul 2019 16:35:59 +0200 > I see, there is a similar statement in mvpp2_port_probe(). > What about adding a static function which sets the flag, and add the > comment there instead of duplicating the comment? That sounds good to me.