From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67833C433FF for ; Sat, 27 Jul 2019 10:51:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B5E520449 for ; Sat, 27 Jul 2019 10:51:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564224683; bh=aC5qgfw92/SyHhkS/dx9G3VFGN8AyvxWdxsBO5J3CLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kqJ1emErY4x/R24K34ITWdu0+vlKnFzHFtFGSd8MPBF3QVeyjvJ5T/R1ij5CezQ3/ erO8oKFqMBBhfSWNdTdUNmYFrPujBDoK12YV1qjUJtMNo14DoE7vsRUwVPtaC/RRdw FeBgGL7SwkoCQDzSZ1Dt5Co1i9CowivUuZdNpA2g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728824AbfG0KvV (ORCPT ); Sat, 27 Jul 2019 06:51:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:38194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725875AbfG0KvV (ORCPT ); Sat, 27 Jul 2019 06:51:21 -0400 Received: from localhost (lfbn-1-17239-195.w86-248.abo.wanadoo.fr [86.248.61.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B0942081B; Sat, 27 Jul 2019 10:51:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564224680; bh=aC5qgfw92/SyHhkS/dx9G3VFGN8AyvxWdxsBO5J3CLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FUBL8iC2OQ/Iglwg6Jc5NYtBB7Vm/CzzU+JLG84hfHyy/3KjvuaCTfk8gZVZGe3l+ jvgXa+7knlA8dhUsXjOeLPFXrGCCNQp/2TqEAFyu7IUg8ly7JlQ8FqK2rsd+PQ+Kx/ RQsTfj02ruUkvhUxBwbOj2wEAIyzfioxipvV9NvA= Date: Sat, 27 Jul 2019 12:51:17 +0200 From: Maxime Ripard To: Jernej Skrabec Cc: thierry.reding@gmail.com, wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 6/6] arm64: dts: allwinner: h6: Add PWM node Message-ID: <20190727105117.rcud3x6oskc43zso@flea.home> References: <20190726184045.14669-1-jernej.skrabec@siol.net> <20190726184045.14669-7-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190726184045.14669-7-jernej.skrabec@siol.net> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 26, 2019 at 08:40:45PM +0200, Jernej Skrabec wrote: > Allwinner H6 PWM is similar to that in A20 except that it has additional > bus clock and reset line. > > Note that first PWM channel is connected to output pin and second > channel is used internally, as a clock source to AC200 co-packaged chip. > This means that any combination of these two channels can be used and > thus it doesn't make sense to add pinctrl nodes at this point. > > Signed-off-by: Jernej Skrabec > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > index e8bed58e7246..c1abd805cfdc 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > @@ -229,6 +229,16 @@ > status = "disabled"; > }; > > + pwm: pwm@300a000 { > + compatible = "allwinner,sun50i-h6-pwm"; > + reg = <0x0300a000 0x400>; > + clocks = <&osc24M>, <&ccu CLK_BUS_PWM>; > + clock-names = "pwm", "bus"; We always have the bus clock first, so I'd really like to keep that. We also usually use mod for the second clock, and not the name of the device itself. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com