linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio: magnetometer: mmc35240: Fix a typo in the name of a constant
@ 2019-07-21 21:35 Christophe JAILLET
  2019-07-27 20:00 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2019-07-21 21:35 UTC (permalink / raw)
  To: jic23, knaack.h, lars, pmeerw, tglx, alexios.zavras, gregkh, kstewart
  Cc: linux-iio, linux-kernel, kernel-janitors, Christophe JAILLET

Everything is about mmc35240_ except MMC53240_WAIT_SET_RESET (3 and 5
switched).

This is likely a typo. Define and use MMC35240_WAIT_SET_RESET instead.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/iio/magnetometer/mmc35240.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c
index 7de10281ad9e..425cdd07b4e5 100644
--- a/drivers/iio/magnetometer/mmc35240.c
+++ b/drivers/iio/magnetometer/mmc35240.c
@@ -53,7 +53,7 @@
 #define MMC35240_CTRL1_BW_SHIFT		0
 
 #define MMC35240_WAIT_CHARGE_PUMP	50000	/* us */
-#define MMC53240_WAIT_SET_RESET		1000	/* us */
+#define MMC35240_WAIT_SET_RESET		1000	/* us */
 
 /*
  * Memsic OTP process code piece is put here for reference:
@@ -225,7 +225,7 @@ static int mmc35240_init(struct mmc35240_data *data)
 	ret = mmc35240_hw_set(data, true);
 	if (ret < 0)
 		return ret;
-	usleep_range(MMC53240_WAIT_SET_RESET, MMC53240_WAIT_SET_RESET + 1);
+	usleep_range(MMC35240_WAIT_SET_RESET, MMC35240_WAIT_SET_RESET + 1);
 
 	ret = mmc35240_hw_set(data, false);
 	if (ret < 0)
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: magnetometer: mmc35240: Fix a typo in the name of a constant
  2019-07-21 21:35 [PATCH] iio: magnetometer: mmc35240: Fix a typo in the name of a constant Christophe JAILLET
@ 2019-07-27 20:00 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-07-27 20:00 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: knaack.h, lars, pmeerw, tglx, alexios.zavras, gregkh, kstewart,
	linux-iio, linux-kernel, kernel-janitors

On Sun, 21 Jul 2019 23:35:33 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> Everything is about mmc35240_ except MMC53240_WAIT_SET_RESET (3 and 5
> switched).
> 
> This is likely a typo. Define and use MMC35240_WAIT_SET_RESET instead.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see what we missed.

Thanks,

Jonathan

> ---
>  drivers/iio/magnetometer/mmc35240.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c
> index 7de10281ad9e..425cdd07b4e5 100644
> --- a/drivers/iio/magnetometer/mmc35240.c
> +++ b/drivers/iio/magnetometer/mmc35240.c
> @@ -53,7 +53,7 @@
>  #define MMC35240_CTRL1_BW_SHIFT		0
>  
>  #define MMC35240_WAIT_CHARGE_PUMP	50000	/* us */
> -#define MMC53240_WAIT_SET_RESET		1000	/* us */
> +#define MMC35240_WAIT_SET_RESET		1000	/* us */
>  
>  /*
>   * Memsic OTP process code piece is put here for reference:
> @@ -225,7 +225,7 @@ static int mmc35240_init(struct mmc35240_data *data)
>  	ret = mmc35240_hw_set(data, true);
>  	if (ret < 0)
>  		return ret;
> -	usleep_range(MMC53240_WAIT_SET_RESET, MMC53240_WAIT_SET_RESET + 1);
> +	usleep_range(MMC35240_WAIT_SET_RESET, MMC35240_WAIT_SET_RESET + 1);
>  
>  	ret = mmc35240_hw_set(data, false);
>  	if (ret < 0)


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-27 20:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-21 21:35 [PATCH] iio: magnetometer: mmc35240: Fix a typo in the name of a constant Christophe JAILLET
2019-07-27 20:00 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).