* [PATCH] arcnet: com90io: Mark expected switch fall-throughs
@ 2019-07-29 11:13 Gustavo A. R. Silva
2019-07-29 16:00 ` Kees Cook
2019-07-29 16:39 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-29 11:13 UTC (permalink / raw)
To: Michael Grzeschik, David S. Miller
Cc: netdev, linux-kernel, Gustavo A. R. Silva, Stephen Rothwell, Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings (Building: powerpc allyesconfig):
drivers/net/arcnet/com90io.c: In function 'com90io_setup':
include/linux/printk.h:304:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/arcnet/com90io.c:365:3: note: in expansion of macro 'pr_err'
pr_err("Too many arguments\n");
^~~~~~
drivers/net/arcnet/com90io.c:366:2: note: here
case 2: /* IRQ */
^~~~
drivers/net/arcnet/com90io.c:367:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
irq = ints[2];
~~~~^~~~~~~~~
drivers/net/arcnet/com90io.c:368:2: note: here
case 1: /* IO address */
^~~~
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/arcnet/com90io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/arcnet/com90io.c b/drivers/net/arcnet/com90io.c
index 2c546013a980..186bbf87bc84 100644
--- a/drivers/net/arcnet/com90io.c
+++ b/drivers/net/arcnet/com90io.c
@@ -363,8 +363,10 @@ static int __init com90io_setup(char *s)
switch (ints[0]) {
default: /* ERROR */
pr_err("Too many arguments\n");
+ /* Fall through */
case 2: /* IRQ */
irq = ints[2];
+ /* Fall through */
case 1: /* IO address */
io = ints[1];
}
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arcnet: com90io: Mark expected switch fall-throughs
2019-07-29 11:13 [PATCH] arcnet: com90io: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-07-29 16:00 ` Kees Cook
2019-07-29 16:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2019-07-29 16:00 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Michael Grzeschik, David S. Miller, netdev, linux-kernel,
Stephen Rothwell
On Mon, Jul 29, 2019 at 06:13:20AM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: powerpc allyesconfig):
>
> drivers/net/arcnet/com90io.c: In function 'com90io_setup':
> include/linux/printk.h:304:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
> printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/arcnet/com90io.c:365:3: note: in expansion of macro 'pr_err'
> pr_err("Too many arguments\n");
> ^~~~~~
> drivers/net/arcnet/com90io.c:366:2: note: here
> case 2: /* IRQ */
> ^~~~
> drivers/net/arcnet/com90io.c:367:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> irq = ints[2];
> ~~~~^~~~~~~~~
> drivers/net/arcnet/com90io.c:368:2: note: here
> case 1: /* IO address */
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/net/arcnet/com90io.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/arcnet/com90io.c b/drivers/net/arcnet/com90io.c
> index 2c546013a980..186bbf87bc84 100644
> --- a/drivers/net/arcnet/com90io.c
> +++ b/drivers/net/arcnet/com90io.c
> @@ -363,8 +363,10 @@ static int __init com90io_setup(char *s)
> switch (ints[0]) {
> default: /* ERROR */
> pr_err("Too many arguments\n");
> + /* Fall through */
> case 2: /* IRQ */
> irq = ints[2];
> + /* Fall through */
> case 1: /* IO address */
> io = ints[1];
> }
> --
> 2.22.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arcnet: com90io: Mark expected switch fall-throughs
2019-07-29 11:13 [PATCH] arcnet: com90io: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:00 ` Kees Cook
@ 2019-07-29 16:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-07-29 16:39 UTC (permalink / raw)
To: gustavo; +Cc: m.grzeschik, netdev, linux-kernel, sfr, keescook
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Mon, 29 Jul 2019 06:13:20 -0500
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: powerpc allyesconfig):
...
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-29 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 11:13 [PATCH] arcnet: com90io: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:00 ` Kees Cook
2019-07-29 16:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).