From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
linux-xfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: lift the xfs writepage code into iomap v3
Date: Sun, 28 Jul 2019 17:06:03 -0700 [thread overview]
Message-ID: <20190729000603.GL1561054@magnolia> (raw)
In-Reply-To: <CAHc6FU7L52soLiRafnOiTsaMYp4X_NmjjimpMMzdaoSH_afT+A@mail.gmail.com>
On Sat, Jul 27, 2019 at 03:33:14PM +0200, Andreas Gruenbacher wrote:
> On Sat, 27 Jul 2019 at 01:38, Darrick J. Wong <darrick.wong@oracle.com> wrote:
> > On Mon, Jul 23, 2019 at 11:50:12AM +0200, Christoph Hellwig wrote:
> > > Hi all,
> > >
> > > this series cleans up the xfs writepage code and then lifts it to
> > > fs/iomap.c so that it could be use by other file system. I've been
> > > wanting to this for a while so that I could eventually convert gfs2
> > > over to it, but I never got to it. Now Damien has a new zonefs
> > > file system for semi-raw access to zoned block devices that would
> > > like to use the iomap code instead of reinventing it, so I finally
> > > had to do the work.
> >
> > Hmm... I don't like how there are xfs changes mixed in with the iomap
> > changes, because were I to take this series as-is then I'd have to
> > commit both to adding iomap writeback code /and/ converting xfs at the
> > same time.
> >
> > I think I'd be more comfortable creating a branch to merge the changes
> > to list.h and fs/iomap/, and then gfs2/zonefs/xfs can sprout their own
> > branches from there to do whatever conversions are necessary.
> >
> > To me what that means is splitting patch 7 into 7a which does the iomap
> > changes and 7b which does the xfs changes. To get there, I'd create a
> > iomap-writeback branch containing:
> >
> > 1 7a 8 9 10 11 12
> >
> > and then a new xfs-iomap-writeback branch containing:
> >
> > 2 4 7b
> >
> > This eliminates the need for patches 3, 5, and 6, though the cost is
> > that it's less clear from the history that we did some reorganizing of
> > the xfs writeback code and then moved it over to iomap. OTOH, I also
> > see this as a way to lower risk because if some patch in the
> > xfs-iomap-writeback branch shakes loose a bug that doesn't affect gfs2
> > or zonedfs we don't have to hold them up.
> >
> > I'll try to restructure this series along those lines and report back
> > how it went.
>
> Keeping the infrastructure changes in separate commits would certainly
> make the patches easier to work with for me. Keeping the commits
> interleaved should be fine though: patch "iomap: zero newly allocated
> mapped blocks" depends on "xfs: set IOMAP_F_NEW more carefully", so a
> pure infrastructure branch without "xfs: set IOMAP_F_NEW more
> carefully" probably wouldn't be correct.
<nod> In the end I went with:
iomap: 1 7a 8 9 10 11 12
and then atop that:
xfs: 2 4 3 5 6 7b
Because xfs can merge the refactoring in patches 2 & 4 without needing
to take patches 3-7b. Will retest overnight with -rc2 (now that scsi
works again <cough>).
--D
> Thanks,
> Andreas
next prev parent reply other threads:[~2019-07-29 0:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 9:50 lift the xfs writepage code into iomap v3 Christoph Hellwig
2019-07-22 9:50 ` [PATCH 01/12] list.h: add list_pop and list_pop_entry helpers Christoph Hellwig
2019-07-22 20:12 ` Matthew Wilcox
2019-07-22 9:50 ` [PATCH 02/12] xfs: initialize iomap->flags in xfs_bmbt_to_iomap Christoph Hellwig
2019-07-22 9:50 ` [PATCH 03/12] xfs: use a struct iomap in xfs_writepage_ctx Christoph Hellwig
2019-07-22 9:50 ` [PATCH 04/12] xfs: refactor the ioend merging code Christoph Hellwig
2019-07-22 9:50 ` [PATCH 05/12] xfs: turn io_append_trans into an io_private void pointer Christoph Hellwig
2019-07-22 9:50 ` [PATCH 06/12] xfs: remove the fork fields in the writepage_ctx and ioend Christoph Hellwig
2019-07-22 9:50 ` [PATCH 07/12] iomap: move the xfs writeback code to iomap.c Christoph Hellwig
2019-07-22 9:50 ` [PATCH 08/12] iomap: add tracing for the address space operations Christoph Hellwig
2019-07-22 9:50 ` [PATCH 09/12] iomap: move struct iomap_page out of iomap.h Christoph Hellwig
2019-07-22 9:50 ` [PATCH 10/12] iomap: warn on inline maps in iomap_writepage_map Christoph Hellwig
2019-07-22 9:50 ` [PATCH 11/12] xfs: set IOMAP_F_NEW more carefully Christoph Hellwig
2019-07-22 9:50 ` [PATCH 12/12] iomap: zero newly allocated mapped blocks Christoph Hellwig
2019-07-22 20:12 ` lift the xfs writepage code into iomap v3 Andreas Gruenbacher
2019-07-26 23:37 ` Darrick J. Wong
2019-07-27 13:33 ` Andreas Gruenbacher
2019-07-29 0:06 ` Darrick J. Wong [this message]
2019-07-30 1:17 ` Darrick J. Wong
2019-07-31 6:04 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729000603.GL1561054@magnolia \
--to=darrick.wong@oracle.com \
--cc=Damien.LeMoal@wdc.com \
--cc=agruenba@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).