From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: ronald@innovation.ch, nikolas@gnu.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: applespi - Fix build error
Date: Mon, 29 Jul 2019 16:04:38 +0200 [thread overview]
Message-ID: <20190729140438.GA2372@penguin> (raw)
In-Reply-To: <20190729031455.59400-1-yuehaibing@huawei.com>
On Mon, Jul 29, 2019 at 11:14:55AM +0800, YueHaibing wrote:
> If CONFIG_KEYBOARD_APPLESPI=y but CONFIG_LEDS_CLASS=m
> building fails:
>
> drivers/input/keyboard/applespi.o: In function `applespi_probe':
> applespi.c:(.text+0x1fcd): undefined reference to `devm_led_classdev_register_ext'
>
> Wrap it in LEDS_CLASS macro to fix this.
No, we should add "depends on LEDS_CLASS" to the Konfig instead.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-07-29 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 3:14 [PATCH] Input: applespi - Fix build error YueHaibing
2019-07-29 14:04 ` Dmitry Torokhov [this message]
2019-07-30 7:01 ` Life is hard, and then you die
2019-07-30 7:22 ` Yuehaibing
2019-07-30 13:34 ` [PATCH v2] " YueHaibing
2019-07-31 13:49 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729140438.GA2372@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikolas@gnu.org \
--cc=ronald@innovation.ch \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).